[17.0][MIG] partner_event: Migration to version 17.0 #382
Conversation
These fields were stored. That usually is good, but if you add partners to an event from the wizard, it means each `res.partner` record gets its `registration_count` field updated.
When you update any record, fields `write_uid` and `write_date` are updated too.
Now imagine you want to add 4000 partners to an event. That would take time. If in the mean time any other user updates the `res.partner` record (along with their `write_UID` and `WRITE_DATE` fields), you would get this error:
```
openerp.sql_db: bad query: UPDATE "res_partner" SET "registration_count"=3,"write_uid"=5,"write_date"=(now() at time zone 'UTC') WHERE id IN (25578)
Traceback (most recent call last):
File "/opt/odoo/common/openerp/v8/openerp/sql_db.py", line 234, in execute
res = self._obj.execute(query, params)
TransactionRollbackError: could not serialize access due to concurrent update
CONTEXT: SQL statement "SELECT 1 FROM ONLY "public"."res_users" x WHERE "id" OPERATOR(pg_catalog.=) $1 FOR KEY SHARE OF x"
```
By removing the `store=True` parameter, you simply avoid those concurrent updates and do not block other users.
But this changes the database structure, so remember to update your database!
If adding 1000 partners, we save now 999 queries. (cherry picked from commit 89853ef)
Currently translated at 100.0% (24 of 24 strings) Translation: event-12.0/event-12.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-12-0/event-12-0-partner_event/es/
…oint For speeding up the process. Specially the removal of the savepoints makes that Postgres don't go slow as hell. Check https://www.cybertec-postgresql.com/en/subtransactions-and-performance-in-postgresql/ for some rationale. The problem happens even releasing the previous savepoints. As this module is very old, the reason for doing it this way and skip registrations with error is not fully known, but the view mentions about registration duplication, so let's avoid it and handle later other possible exceptions. TT26694
When we confirm a sale order, the registrations are precreated without the email info, so we were missing the chance to get the info for the partner attendant. Now we compute it on the write as well. TT45149
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/
Currently translated at 100.0% (23 of 23 strings) Translation: event-16.0/event-16.0-partner_event Translate-URL: https://translation.odoo-community.org/projects/event-16-0/event-16-0-partner_event/es/
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-partner_event
branch
from
35da533 to
99ae14a
Compare
|
/ocabot migration partner_event |
partner_event/models/res_partner.py
Outdated
| string="Attendances", compute="_compute_registration_count", store=False | ||
| ) | ||
|
|
||
| @api.depends("event_registration_ids") |
There was a problem hiding this comment.
Instead of calling invalidate_recordset() in tests (which is somehow making tricks), you must add here in this depends the subfields (like event_registration_ids.state) for triggering the recompute automatically, as this is also going to provoke errors on its usage.
There was a problem hiding this comment.
Done!
The tests pass perfectly with the change.
There was a problem hiding this comment.
The change is not correct. You have to add both, event_registration_ids and event_registration_ids.state, and any other field that can impact, and remove the invalidate_recordset calls in the tests.
There was a problem hiding this comment.
Ok, I have applied the changes and everything works correctly.
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-partner_event
branch
2 times, most recently
from
8daab18 to
0db6580
Compare
|
/ocabot migration partner_event |
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-partner_event
branch
2 times, most recently
from
fca4baa to
c7ab611
Compare
juanjosesegui-tecnativa
force-pushed
the
17.0-mig-partner_event
branch
from
c7ab611 to
148c4d5
Compare
|
This PR has the |
|
/ocabot merge nobump |
|
This PR looks fantastic, let's merge it! |
|
Congratulations, your PR was merged at f2c791c. Thanks a lot for contributing to OCA. ❤️ |
@Tecnativa TT49923