[18.0][ADD] delivery_carrier_package_info #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imlopes
force-pushed
the
18.0-add-delivery_carrier_package_info
branch
from
eb0cdc4 to
c5a5381
Compare
|
The fields created on this PR already exists on https://github.com/OCA/delivery-carrier/pull/974/files#diff-5971767dc0fddad43744d6207d82724d9cfd1c288dd6f6716333a58c20af4fd7 Closing |
|
Please reopen, it's a good idea to extract these fields in a separate module |
StephaneMangin
approved these changes
Feb 18, 2025
|
I'm fine with single purpose modules, but I'm against extracting this while the other PR isn't merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
extracted from
base_delivery_carrier_label#896