[MIG][BACKPORT][12.0] ddmrp #63

mileo · 2020-08-20T03:49:56Z

No description provided.

Sometimes procurements are over-fulfilled so the subtract qty becomes negative, we don't want to apply it in that case, since we will be taking into account some stock moves twice.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/

Currently translated at 6.1% (15 of 247 strings) Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/fr/

Currently translated at 15.0% (37 of 247 strings) Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/fr/

Signed-off-by: Luis Felipe Mileo <[email protected]>

OCA-git-bot · 2020-08-20T05:43:24Z

Hi @JordiBForgeFlow, @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

max3903 · 2021-09-09T10:32:17Z

@mileo I get the following error message when confirming a purchase order created from the buffer:

Error:
Odoo Server Error

Traceback (most recent call last):
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 654, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 312, in _handle_exception
    raise pycompat.reraise(type(exception), exception, sys.exc_info()[2])
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/tools/pycompat.py", line 87, in reraise
    raise value
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 696, in dispatch
    result = self._call_function(**self.params)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 344, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/service/model.py", line 97, in wrapper
    return f(dbname, *args, **kwargs)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 337, in checked_call
    result = self.endpoint(*a, **kw)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 939, in __call__
    return self.method(*args, **kw)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/http.py", line 517, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/odoo/addons/web/controllers/main.py", line 967, in call_button
    action = self._call_kw(model, method, args, {})
  File "/opt/odoo/odoo/addons/web/controllers/main.py", line 955, in _call_kw
    return call_kw(request.env[model], method, args, kwargs)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/api.py", line 749, in call_kw
    return _call_kw_multi(method, model, args, kwargs)
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/api.py", line 736, in _call_kw_multi
    result = method(recs, *args, **kwargs)
  File "/opt/odoo/odoo/addons/purchase/models/purchase.py", line 330, in button_confirm
    order.button_approve()
  File "/opt/odoo/odoo/addons/purchase_stock/models/purchase.py", line 87, in button_approve
    self._create_picking()
  File "/opt/odoo/odoo/addons/purchase_stock/models/purchase.py", line 209, in _create_picking
    moves = moves.filtered(lambda x: x.state not in ('done', 'cancel'))._action_confirm()
  File "/opt/odoo/odoo/addons/mrp/models/stock_move.py", line 152, in _action_confirm
    return super(StockMove, moves)._action_confirm(merge=merge, merge_into=merge_into)
  File "/opt/odoo/odoo/addons/stock/models/stock_move.py", line 767, in _action_confirm
    move_to_confirm.write({'state': 'confirmed'})
  File "/opt/odoo/src/oca-addons/ddmrp/models/stock_move.py", line 27, in write
    if "state" in vals and self.company_id.ddmrp_auto_update_nfp:
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/fields.py", line 969, in __get__
    record.ensure_one()
  File "/opt/odoo/env/lib/python3.6/site-packages/odoo-12.0-py3.6.egg/odoo/models.py", line 4662, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: stock.move(435711, 435712, 435713, 435714, 435715, 435716, 435717, 435718, 435719, 435720, 435721, 435722, 435723, 435724, 435725, 435726, 435727, 435728, 435729, 435730, 435731, 435732, 435733, 435734, 435735, 435736, 435737, 435738, 435739, 435740, 435741, 435742, 435743, 435744, 435745, 435746, 435747, 435748, 435749)

bodedra · 2021-09-09T16:11:52Z

ddmrp/models/stock_move.py

+        if "state" in vals and self.company_id.ddmrp_auto_update_nfp:
+            self._update_ddmrp_nfp()


Suggested change

if "state" in vals and self.company_id.ddmrp_auto_update_nfp:

self._update_ddmrp_nfp()

if "state" in vals:

for move in self.filtered(lambda m: m.company_id.ddmrp_auto_update_nfp):

move._update_ddmrp_nfp()

max3903 · 2021-09-23T17:06:15Z

@mileo kmee#1

[FIX] ddmrp: ValueError: Expected singleton: stock.move(...)

max3903 · 2021-09-24T19:59:04Z

ddmrp/models/purchase_order.py

+    def _calc_execution_priority(self):
+        # TODO: handle serveral buffers? worst scenario, average?
+        to_compute = self.filtered(
+            lambda r: r.buffer_ids and r.state not in ["done", "cancel"]


@mileo If you activate the purchase lock option in Purchase settings, when confirming the PO, the lines are already in state done when reaching this line and so the execution_priority_level and on_hand_percent are set to None.

CC: @LoisRForgeFlow

@mileo @LoisRForgeFlow See kmee#2 for a possible solution. Feel free to implement a better one.

github-actions · 2022-01-30T12:29:31Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

JordiBForgeFlow and others added 30 commits August 19, 2020 18:22

[IMP] Major improvements. This is rolling!!

aea5a61

[IMP] add security rules

9656acd

[FIX] change method to create procurements from buffers

2257376

[FIX] pass extra data to procurement

4919e5e

[FIX] various fixes and improvements

31020ab

[FIX] various fixes

398952d

[FIX] various fixes

b60ea2c

[FIX] various fixes and improvements

b79012f

[FIX] various fixes and improvements

de54163

[IMP] split demand estimate to a separate module

41ccf15

[FIX] filter execution priority level only on open manufacturing orders

2650efa

[IMP] search optimization

4303cc4

[FIX] fix search

5834f90

[FIX] search optimization

7869859

[FIX] fix search optimization

3ae320f

[FIX] search optimization

5a7f932

[FIX] update stock_demand_estimate

f7ac03d

[IMP] add tests

d1cae54

[FIX] fix buffer view

f7b1d28

[FIX] access to open uncompleted moves

795fdc5

[IMP] improve tests

f99beb2

[IMP] various improvements

4dcbfa0

Migration to v9

f5c24aa

fix

c6d75f4

improve compute_orderpoint

6bc67d8

[FIX] internal moves are not considered demand

63f3a9f

fix incorrect procure_recommended_qty

e4a85b0

[9.0][FIX] subtract qty only if positive.

1cb2c03

Sometimes procurements are over-fulfilled so the subtract qty becomes negative, we don't want to apply it in that case, since we will be taking into account some stock moves twice.

[9.0] ddmrp: able to sort by priority in manufacturing orders.

40fe2cb

[9.0][IMP] ddmrp: enhance extensibility of cron_ddmrp.

74daf4b

OCA-git-bot and others added 16 commits August 19, 2020 18:22

[UPD] changelog

63014f8

[UPD] README.rst

81c7819

ddmrp 13.0.1.1.0

469357d

Update translation files

fbbd6bf

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/

[13.0][UPD] ddmrp: add ddmrp_adjustment to setting wizard

1411f3e

[UPD] Update ddmrp.pot

f22f75f

Update translation files

e475baf

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/

[13.0][UPD] ddmrp: add latest modules to settings panel

2db7a07

[UPD] Update ddmrp.pot

52aee6d

Update translation files

3161695

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/

Translated using Weblate (French)

dc67b2d

Currently translated at 6.1% (15 of 247 strings) Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/fr/

Translated using Weblate (French)

49fd304

Currently translated at 15.0% (37 of 247 strings) Translation: ddmrp-13.0/ddmrp-13.0-ddmrp Translate-URL: https://translation.odoo-community.org/projects/ddmrp-13-0/ddmrp-13-0-ddmrp/fr/

[MIG][BACKPORT] ddmrp installable

d42ef45

Signed-off-by: Luis Felipe Mileo <[email protected]>

[MIG] digits precision

6242c91

Signed-off-by: Luis Felipe Mileo <[email protected]>

[MIG] button active

04d3e56

Signed-off-by: Luis Felipe Mileo <[email protected]>

[MIG] Backport procurements

1513e48

Signed-off-by: Luis Felipe Mileo <[email protected]>

max3903 added this to the 12.0 milestone Aug 26, 2021

max3903 mentioned this pull request Sep 9, 2021

Migration to version 12.0 #25

Closed

23 tasks

bodedra reviewed Sep 9, 2021

View reviewed changes

[FIX] ddmrp: ValueError: Expected singleton: stock.move(...)

7c8772e

Merge pull request #1 from ursais/12.0-MIG-ddmrp

f9df47f

[FIX] ddmrp: ValueError: Expected singleton: stock.move(...)

max3903 reviewed Sep 24, 2021

View reviewed changes

max3903 added migration needs fixing labels Sep 27, 2021

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 30, 2022

github-actions bot closed this Mar 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MIG][BACKPORT][12.0] ddmrp #63

[MIG][BACKPORT][12.0] ddmrp #63

mileo commented Aug 20, 2020

OCA-git-bot commented Aug 20, 2020

max3903 commented Sep 9, 2021

bodedra Sep 9, 2021

max3903 commented Sep 23, 2021

max3903 Sep 24, 2021 •

edited

Loading

max3903 Sep 27, 2021

github-actions bot commented Jan 30, 2022

		if "state" in vals and self.company_id.ddmrp_auto_update_nfp:
		self._update_ddmrp_nfp()

-        if "state" in vals and self.company_id.ddmrp_auto_update_nfp:
-            self._update_ddmrp_nfp()
+        if "state" in vals:
+            for move in self.filtered(lambda m: m.company_id.ddmrp_auto_update_nfp):
+                move._update_ddmrp_nfp()

[MIG][BACKPORT][12.0] ddmrp #63

[MIG][BACKPORT][12.0] ddmrp #63

Conversation

mileo commented Aug 20, 2020

OCA-git-bot commented Aug 20, 2020

max3903 commented Sep 9, 2021

bodedra Sep 9, 2021

Choose a reason for hiding this comment

max3903 commented Sep 23, 2021

max3903 Sep 24, 2021 • edited Loading

Choose a reason for hiding this comment

max3903 Sep 27, 2021

Choose a reason for hiding this comment

github-actions bot commented Jan 30, 2022

max3903 Sep 24, 2021 •

edited

Loading