[18.0][MIG] base_bank_from_iban: Migration to 18.0 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100.0% (7 of 7 strings) Translation: community-data-files-14.0/community-data-files-14.0-base_bank_from_iban Translate-URL: https://translation.odoo-community.org/projects/community-data-files-14-0/community-data-files-14-0-base_bank_from_iban/nl/
It complies with the requirements and other modules depending on it are also mature.
- Regenerate README - Journal code removed, as you cannot specify the bank account number from it. - Added the equivalente code for the add bank account wizard. TT40005
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: community-data-files-16.0/community-data-files-16.0-base_bank_from_iban Translate-URL: https://translation.odoo-community.org/projects/community-data-files-16-0/community-data-files-16-0-base_bank_from_iban/
Currently translated at 100.0% (4 of 4 strings) Translation: community-data-files-16.0/community-data-files-16.0-base_bank_from_iban Translate-URL: https://translation.odoo-community.org/projects/community-data-files-16-0/community-data-files-16-0-base_bank_from_iban/hr/
Currently translated at 100.0% (4 of 4 strings) Translation: community-data-files-16.0/community-data-files-16.0-base_bank_from_iban Translate-URL: https://translation.odoo-community.org/projects/community-data-files-16-0/community-data-files-16-0-base_bank_from_iban/es/
Currently translated at 100.0% (4 of 4 strings) Translation: community-data-files-17.0/community-data-files-17.0-base_bank_from_iban Translate-URL: https://translation.odoo-community.org/projects/community-data-files-17-0/community-data-files-17-0-base_bank_from_iban/it/
If any non IBAN account is provided, there's an ugly log with traceback
each time, polluting tests and system logs:
```
INFO prod odoo.addons.base_bank_from_iban.models.res_partner_bank: Could not find bank from IBAN
Traceback (most recent call last):
File ".../addons/base_bank_from_iban/models/res_partner_bank.py", line 34, in _add_bank_vals
bank = self._get_bank_from_iban(vals["acc_number"])
File ".../addons/base_bank_from_iban/models/res_partner_bank.py", line 42, in _get_bank_from_iban
iban = schwifty.IBAN(acc_number)
File ".../python/site-packages/schwifty/iban.py", line 77, in __init__
self.validate(validate_bban)
File ".../python/site-packages/schwifty/iban.py", line 175, in validate
self._validate_characters()
File ".../python/site-packages/schwifty/iban.py", line 185, in _validate_characters
raise exceptions.InvalidStructure(f"Invalid characters in IBAN {self!s}")
schwifty.exceptions.InvalidStructure: Invalid characters in IBAN XXXXXX
```
This commit removes that traceback catching the proper exception, and
handling it accordingly, and also removing an extra INFO log that was
not adding value.
Previous code using the XML-IDs has 2 problems: - If not found, it returns False instead of an empty recordset, giving error later on the code when accessing `country.id`. - The XML-IDs are not the same as the country codes. Example, United Kingdom is `base.uk`, not `base.gb`. Then, let's search the country by code directly for tackling both problems.
peluko00
suggested changes
Feb 10, 2025
mpascuall
force-pushed
the
18.0-mig-base_bank_from_iban
branch
from
927f526 to
ac46ccd
Compare
pedrobaeza
requested changes
Feb 10, 2025
mpascuall
force-pushed
the
18.0-mig-base_bank_from_iban
branch
from
ac46ccd to
dec7a7a
Compare
|
On my way to merge this fine PR! |
|
Congratulations, your PR was merged at e7b0589. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module migrated to version 18.0
cc https://github.com/APSL 166745
@miquelalzanillas @lbarry-apsl @javierobcn @peluko00 @ppyczko @BernatObrador please review