Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] base_currency_iso_4217: Migration to 16.0 #171

Merged
merged 10 commits into from
Aug 29, 2023
Merged

[16.0][MIG] base_currency_iso_4217: Migration to 16.0 #171

merged 10 commits into from
Aug 29, 2023

Conversation

BT-anieto
Copy link
Contributor

No description provided.

@BT-anieto BT-anieto mentioned this pull request Aug 4, 2023
Open
9 tasks
@BT-anieto
Copy link
Contributor Author

Good morning @JordiBForgeFlow Could you take a look? Thanks before hand

BT-aleonard
BT-aleonard approved these changes Aug 7, 2023
View reviewed changes
Copy link

@BT-aleonard BT-aleonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM, thanks for migrating!

BT-mrobles
BT-mrobles approved these changes Aug 11, 2023
View reviewed changes
Copy link

@BT-mrobles BT-mrobles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@BT-anieto
Copy link
Contributor Author

Good morning @pedrobaeza,

Could you check this PR? I don't know who to contact since there is no maintainer (or at least I don't know where to find it

Thank you very much

@pedrobaeza
Copy link
Member

/ocabot migration base_currency_iso_4217
/ocabot merge nobump

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Aug 29, 2023
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-171-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 79a6e84 into OCA:16.0 Aug 29, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 861759a. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BT-aleonard BT-aleonard BT-aleonard approved these changes

@BT-mrobles BT-mrobles BT-mrobles approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.