Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_tax_unece: Migration to 16.0 #146

Merged
merged 24 commits into from
Dec 1, 2022

Conversation

syera94
Copy link
Contributor

@syera94 syera94 commented Nov 4, 2022

@alexis-via @astirpe hey guys, could you please check this PR if it's OK for you.

@alexis-via
Copy link
Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Sorry @alexis-via you are not allowed to merge.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@alexis-via
Copy link
Contributor

arf, stupid bot... I'm the declared maintainer !

@alexis-via
Copy link
Contributor

Anyone with the super-powers to merge this?

@pedrobaeza
Copy link
Member

/ocabot merge nobump
/ocabot migration account_tax_unece

Next time please modify the PR title to conform guidelines: [16.0][MIG] account_tax_unece: Migration to 16.0.

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Dec 1, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Dec 1, 2022
9 tasks
@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-146-by-pedrobaeza-bump-nobump, awaiting test results.

@pedrobaeza pedrobaeza changed the title 16.0 mig account tax unece [16.0][MIG] account_tax_unece: Migration to 16.0 Dec 1, 2022
@OCA-git-bot OCA-git-bot merged commit 803801f into OCA:16.0 Dec 1, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 52bb00d. Thanks a lot for contributing to OCA. ❤️

@bealdav
Copy link
Member

bealdav commented Dec 1, 2022

@pedrobaeza it seems commit were done with oca-port

@bealdav bealdav deleted the 16.0-mig-account_tax_unece branch December 1, 2022 13:10
@pedrobaeza
Copy link
Member

Well, the PR title is got from the branch, and it should be manually modified. Not doing it, it's the lazy option, coming from oca-port or manual process.

@bealdav
Copy link
Member

bealdav commented Dec 1, 2022

FYI I'm lazy and proud of it :-)

@bealdav
Copy link
Member

bealdav commented Dec 1, 2022

Why not modify oca-port ?

@pedrobaeza
Copy link
Member

I don't think that's possible, unless GitHub offers a way through the URL to set the PR title.

@bealdav
Copy link
Member

bealdav commented Dec 2, 2022

I think we should update oca-port to generate branch as 16.0-MIG-my-module instead of 16.0-mig-my-module and update guideline to this new rule
If not, I'm afraid you'll got spend 2 hours a day to ask people update their PR title

@pedrobaeza
Copy link
Member

That's not correct. Even with that branch name, the PR title won't be correct, as it's extracted for PR title as 16.0 MIG my module, leading that it you search for my_module to check if there's other opened PRs, you won't find them. And in any case, it's module_migrator the tool for doing migrations, not oca-port (although it makes one part of the work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants