[18.0] [MIG] account_payment_term_extension: Migration to 18.0

[TheMule71]

Replaces #776

[TheMule71]

I do have a question, according to the migration guidelines, you should

Remove references in CREDITS.rst of past financed migrations by other companies.

which I did, but I'm not totally comfortable with. The previous credits were for the 15.0->16.0 migration, and survived the 16.0 -> 17.0 migration. Should I keep them?

[gdemarco2esseti]

Functional review: KO

Whenever a change is made in the configuration, the following error appears when attempting to save:

Odoo Server Error

RPC_ERROR
Odoo Server Error

Occured on oca-account-payment-18-0-pr788-a28fe61a9e54.runboat.odoo-community.org on model account.payment.term and id 71 on 2025-02-07 09:25:03 GMT

Traceback (most recent call last):
File "/opt/odoo/odoo/http.py", line 1961, in _transactioning
return service_model.retrying(func, env=self.env)
File "/opt/odoo/odoo/service/model.py", line 137, in retrying
result = func()
File "/opt/odoo/odoo/http.py", line 1928, in _serve_ir_http
response = self.dispatcher.dispatch(rule.endpoint, args)
File "/opt/odoo/odoo/http.py", line 2176, in dispatch
result = self.request.registry['ir.http']._dispatch(endpoint)
File "/opt/odoo/odoo/addons/base/models/ir_http.py", line 329, in _dispatch
result = endpoint(**request.params)
File "/opt/odoo/odoo/http.py", line 727, in route_wrapper
result = endpoint(self, *args, **params_ok)
File "/opt/odoo/addons/web/controllers/dataset.py", line 35, in call_kw
return call_kw(request.env[model], method, args, kwargs)
File "/opt/odoo/odoo/api.py", line 517, in call_kw
result = getattr(recs, name)(*args, **kwargs)
File "/opt/odoo/addons/web/models/models.py", line 70, in web_save
self.write(vals)
File "/opt/odoo/odoo/models.py", line 4749, in write
field.write(self, value)
File "/opt/odoo/odoo/fields.py", line 4496, in write
self.write_batch([(records, value)])
File "/opt/odoo/odoo/fields.py", line 4517, in write_batch
self.write_real(records_commands_list, create)
File "/opt/odoo/odoo/fields.py", line 4686, in write_real
comodel.browse(command[1]).with_prefetch(prefetch_ids).write(command[2])
File "/opt/odoo/odoo/models.py", line 4771, in write
real_recs._validate_fields(vals, inverse_fields)
File "/opt/odoo/odoo/models.py", line 1599, in _validate_fields
check(self)
File "/mnt/data/odoo-addons-dir/account_payment_term_extension/models/account_payment_term_line.py", line 100, in _check_payment_days
raise exceptions.Warning(
AttributeError: module 'odoo.exceptions' has no attribute 'Warning'

The above server error caused the following client error:
RPC_ERROR: Odoo Server Error
RPC_ERROR
at makeErrorFromResponse (http://oca-account-payment-18-0-pr788-a28fe61a9e54.runboat.odoo-community.org/web/assets/50cbccd/web.assets_web.min.js:3134:163)
at XMLHttpRequest. (http://oca-account-payment-18-0-pr788-a28fe61a9e54.runboat.odoo-community.org/web/assets/50cbccd/web.assets_web.min.js:3139:13)

[TheMule71]

Functional review: KO

Whenever a change is made in the configuration, the following error appears when attempting to save:

It happens only when a mistake is made when configuring the module. Eg. this is a screenshot from my tests on runboat:

Nicely spotted, it's there since 14.0, although the deprecation warning was visibile only in the logs.

Fixed.

[TheMule71]

Test on runboat:

this is the exception to be displayed. Warning is no longer valid and has been deprecated since 14.0.