[16.0][MIG] partner_aging

[cormaza]

No description provided.

[yboujraf]

Dear @cormaza
Do you know why the module is not released ?
BR

[cormaza]

Dear @cormaza Do you know why the module is not released ? BR

It should be approved at least by two reviewers, then some maintainer can merge

[miquelalzanillas]

Hi @cormaza ,

Could you please rebase?

Thanks!

[cormaza]

/ocabot rebase

[OCA-git-bot]

Sorry @cormaza you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

[miquelalzanillas]

Code and functional review. LGTM.

[miquelalzanillas]

Dear @cormaza Do you know why the module is not released ? BR

Hi @yboujraf ,

You can tests this module on runboat using the link here.

If your tests are ok, you can approve this pull request using this.

Thanks!

[ppyczko]

Please, rename the pull request and commit following this pattern: [16.0][MIG] <module>: Migration to 16.0

Otherwise, LGTM, tested in runboat

[mpascuall]

LGTM, tested in runboat

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[miquelalzanillas]

Hi @pedrobaeza ,

Could you review please?

[peluko00]

Can you fix the itinerary to access to the module:

#. Go to Invoicing
#. Click on Customers > Customer Aging or Vendors > Supplier Aging
#. Change the date if necessary

[miquelalzanillas]

Hi @pedrobaeza ,

we need to start migration to v17, do you think this is ready to merge?

Thanks,

[pedrobaeza]

/ocabot migration partner_aging

I don't use this module. A PSC should review it.

[miquelalzanillas]

Hi @HaraldPanten ,

Could you check if we can merge this module?

Thanks,

[HaraldPanten]

Hi @HaraldPanten ,

Could you check if we can merge this module?

Thanks,

Hi @miquelalzanillas I'm not using this module neither, but I see that there's something wrong with the commit history. You should check it 👍

[miquelalzanillas]

Hi @HaraldPanten ,
Could you check if we can merge this module?
Thanks,

Hi @miquelalzanillas I'm not using this module neither, but I see that there's something wrong with the commit history. You should check it 👍

Hi @cormaza , can you check it?

Thanks.

[cormaza]

Hi @HaraldPanten ,
Could you check if we can merge this module?
Thanks,

Hi @miquelalzanillas I'm not using this module neither, but I see that there's something wrong with the commit history. You should check it 👍

Hi @HaraldPanten, thank you for review, I can't see commit history problem, can you specific where is it?

[HaraldPanten]

I see... It seems that it's due to the name change to partner_aging.

Even though, you're not following the proper name for the migration commit. Could you check it?

[miquelalzanillas]

Hi @cormaza ,

I think what Harald means is to update your migration commit message from [16.0][MIG] partner_aging to [MIG][16.0] partner_aging:Migration to 16.0.

Can you do it please?

Thanks!

[HaraldPanten]

Hi @cormaza ,

I think what Harald means is to update your migration commit message from [16.0][MIG] partner_aging to [MIG][16.0] partner_aging:Migration to 16.0.

Can you do it please?

Thanks!

That's it. THX Miquel.

[HaraldPanten]

Oops, the name should appear without the module version, sorry. It should have this name:

[MIG] partner_aging: Migration to 16.0

[HaraldPanten]

Merging, as it has several validations

[HaraldPanten]

/ocabot merge nobump

[OCA-git-bot]

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-733-by-HaraldPanten-bump-nobump, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 882f4c0. Thanks a lot for contributing to OCA. ❤️

[HaraldPanten]

@miquelalzanillas done 👍

[miquelalzanillas]

Thanks @HaraldPanten & @cormaza !