[16.0][MIG] account_payment_term_extension #580

anothingguy · 2023-02-01T10:54:44Z

since v16, Odoo now supports months natively, but not weeks and not some other features of this module, so it's still worth migrating it
option after_invoice_month can be used alternatively with flag end_month in v16

…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation

Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module

[UPD] Update account_payment_term_extension.pot

Closes OCA#527

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/es/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/pt_BR/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/fr/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/fr_CH/

Currently translated at 85.7% (24 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/hr/

…s precision_digits

Currently translated at 100.0% (28 of 28 strings) Translation: account-payment-13.0/account-payment-13.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-13-0/account-payment-13-0-account_payment_term_extension/es_AR/

…ion in payment term lines

…re resilient * A `account.journal` record was being searched and used to create invoices, even though it was not necessary. This introduced the problem of finding more than one record that satisfied the search query, breaking the test for a singleton error. This removes the need for that. * Extract a method for creating the invoice. * Don't depend on variable year for tests. TT27288 Co-Authored-By: Pedro M. Baeza <[email protected]>

* Standard procedure * Adapt code * Adapt tests * Convert tests to SavepointCase [UPD] Update account_payment_term_extension.pot

…F part

…and weeks fix computing months and weeks

Currently translated at 100.0% (34 of 34 strings) Translation: account-payment-15.0/account-payment-15.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_term_extension/ca/

Currently translated at 100.0% (34 of 34 strings) Translation: account-payment-15.0/account-payment-15.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-15-0/account-payment-15-0-account_payment_term_extension/pt_BR/

pablontura · 2023-02-13T10:34:06Z

Functional validation LGTM

leemannd · 2023-02-20T10:48:56Z

Hello @anothingguy , could you have a look at the pre-commit?

cyrilmanuel · 2023-02-20T11:15:50Z

LGTM :
pre-commit can be resolve regarding this :

OCA/oca-addons-repo-template#185

create new PR: checkout the branch (eg: 16.0) fork it and run copier -f update

StephaneMangin · 2023-03-09T09:37:06Z

Hello @anothingguy , could you have a look at the pre-commit please?

anothingguy · 2023-03-09T10:08:39Z

Hello @anothingguy , could you have a look at the pre-commit please?

Hello @StephaneMangin, pre-commit is green now

OCA-git-bot · 2023-03-09T10:27:23Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

simahawk · 2023-03-09T10:40:33Z

@anothingguy next time, please, fix the module name in the title of the PR: it makes easier to find it while searching for PRs.

/ocabot migration account_payment_term_extension

simahawk · 2023-03-09T10:43:22Z

/ocabot merge nobump

OCA-git-bot · 2023-03-09T10:43:29Z

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-580-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2023-03-09T10:48:01Z

@simahawk The merge process could not be finalized, because command git push origin 16.0-ocabot-merge-pr-580-by-simahawk-bump-nobump:16.0 failed with output:

To https://github.com/OCA/account-payment
 ! [rejected]        16.0-ocabot-merge-pr-580-by-simahawk-bump-nobump -> 16.0 (fetch first)
error: failed to push some refs to 'https://***@github.com/OCA/account-payment'
hint: Updates were rejected because the remote contains work that you do
hint: not have locally. This is usually caused by another repository pushing
hint: to the same ref. You may want to first integrate the remote changes
hint: (e.g., 'git pull ...') before pushing again.
hint: See the 'Note about fast-forwards' in 'git push --help' for details.

OCA-git-bot · 2023-03-09T10:48:03Z

Congratulations, your PR was merged at 765e788. Thanks a lot for contributing to OCA. ❤️

rafaelbn · 2023-08-04T07:29:17Z

This migration has an issue , we are loosing functionality:

#656

Alexis de Lattre and others added 30 commits January 18, 2023 11:18

Port module payment_term_rounding to v8 and rename to account_payment…

d18448a

…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation

OCA Transbot updated translations from Transifex

090e20c

Migration V9 account_payment_term_extension

866de28

Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module

[IMP] account_payment_term_extension: Switch company

4454cbb

OCA Transbot updated translations from Transifex

8e0b47d

Port account_payment_term_extension to v10

4b1d739

OCA Transbot updated translations from Transifex

1af8ed5

[UPD] Module account_payment_term_extension, added holidays management

9e20032

OCA Transbot updated translations from Transifex

4626960

[MIG] account_payment_term_extension: Migration to 11.0

70bf630

OCA Transbot updated translations from Transifex

ba5a01c

[MIG] account_payment_term_extension: Migration to 12.0

866cd9b

[UPD] Update account_payment_term_extension.pot

[FIX] account_payment_term_extension: Add payment_days to view

90ebdbb

Closes OCA#527

12.0 [FIX] the sequential line was not visible

d82b35d

[IMP] account_payment_term_extension: black, isort, prettier

6647c48

[MIG] account_payment_term_extension: Migration to 13.0

b64e250

[FIX] account_payment_term_extension: bad use of precision_rounding v…

e33a802

…s precision_digits

[IMP] account_payment_term_extension: Add amount_untaxed to value opt…

58ff917

…ion in payment term lines

[IMP] account_payment_term_extension: black, isort, prettier

2ed4f70

[MIG+IMP] account_payment_term_extension: Migration to 14.0

c31d8d0

* Standard procedure * Adapt code * Adapt tests * Convert tests to SavepointCase [UPD] Update account_payment_term_extension.pot

[FIX] account_payment_term_extension missing standard option into ELI…

4142dcb

…F part

[ADD][14.0] account_payment_term_discount

d5ef75d

[14.0] [account_payment_term_extension] [FIX] error computing months …

d3cfd6b

…and weeks fix computing months and weeks

OCA-git-bot and others added 4 commits January 18, 2023 11:27

[UPD] README.rst

fdbe7e7

[IMP] account_payment_term_extension: black, isort, prettier

e434e9d

anothingguy mentioned this pull request Feb 1, 2023

Migration to version 16.0 #546

Open

14 tasks

leemannd approved these changes Feb 20, 2023

View reviewed changes

cyrilmanuel approved these changes Feb 20, 2023

View reviewed changes

OCA-git-bot added the approved label Feb 20, 2023

[16.0][MIG] account_payment_term_extension: Migration to 16.0

fe99ad1

anothingguy force-pushed the 16.0-mig-account_payment_term_extension branch from 7dd0a1b to fe99ad1 Compare March 9, 2023 10:03

OCA-git-bot added the ready to merge label Mar 9, 2023

simahawk changed the title ~~16.0 mig account payment term extension~~ [16.0][MIG] account_payment_term_extension Mar 9, 2023

OCA-git-bot added this to the 16.0 milestone Mar 9, 2023

OCA-git-bot added the bot is merging ⏳ label Mar 9, 2023

OCA-git-bot merged commit 460e8c3 into OCA:16.0 Mar 9, 2023

OCA-git-bot removed the bot is merging ⏳ label Mar 9, 2023

OCA-git-bot added the merged 🎉 label Mar 9, 2023

rafaelbn mentioned this pull request Jul 19, 2023

[16] account_payment_term_extension: lost "Payment day(s)" #656

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] account_payment_term_extension #580

[16.0][MIG] account_payment_term_extension #580

anothingguy commented Feb 1, 2023

pablontura commented Feb 13, 2023

leemannd commented Feb 20, 2023

cyrilmanuel commented Feb 20, 2023

StephaneMangin commented Mar 9, 2023

anothingguy commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

simahawk commented Mar 9, 2023

simahawk commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

rafaelbn commented Aug 4, 2023

[16.0][MIG] account_payment_term_extension #580

[16.0][MIG] account_payment_term_extension #580

Conversation

anothingguy commented Feb 1, 2023

pablontura commented Feb 13, 2023

leemannd commented Feb 20, 2023

cyrilmanuel commented Feb 20, 2023

StephaneMangin commented Mar 9, 2023

anothingguy commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

simahawk commented Mar 9, 2023

simahawk commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

OCA-git-bot commented Mar 9, 2023

rafaelbn commented Aug 4, 2023