[9.0][FIX] account_chart_update: Check fiscal positions with same name #651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you sure you should block? Maybe it's better to select the first one, and let the user to change that selection. |
|
@pedrobaeza I blocked it because is better than an unhandled exception. but maybe it is better option to select the first one. Changed it. |
|
I think you have dug too deeper in the compare methods. It's better to put |
|
Okay, I put the limit in the search of fiscal positions. |
pedrobaeza
approved these changes
May 9, 2018
pedrobaeza
pushed a commit
that referenced
this pull request
Sep 18, 2018
bealdav
pushed a commit
to akretion/account-financial-tools
that referenced
this pull request
Feb 26, 2019
ernestotejeda
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Mar 15, 2019
ernestotejeda
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Jan 17, 2020
Reyes4711-S73
pushed a commit
to Studio73/account-financial-tools
that referenced
this pull request
Mar 8, 2021
flachica
pushed a commit
to flachica/account-financial-tools
that referenced
this pull request
Feb 23, 2022
flachica
pushed a commit
to flachica/account-financial-tools
that referenced
this pull request
Apr 4, 2022
flachica
pushed a commit
to flachica/account-financial-tools
that referenced
this pull request
Apr 9, 2022
ljsalvatierra-factorlibre
pushed a commit
to factorlibre/account-financial-tools
that referenced
this pull request
Jan 18, 2023
peluko00
pushed a commit
to APSL/account-financial-tools
that referenced
this pull request
Apr 30, 2024
dreispt
pushed a commit
to ursais/account-financial-tools
that referenced
this pull request
May 24, 2024
victoralmau
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Nov 18, 2024
victoralmau
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Dec 12, 2024
victoralmau
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Dec 19, 2024
victoralmau
pushed a commit
to Tecnativa/account-financial-tools
that referenced
this pull request
Feb 4, 2025
pablo-cort-s73
pushed a commit
to Studio73/account-financial-tools
that referenced
this pull request
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR checks if there is more than one fiscal position with same name and handles the exception, preventing Odoo crash.
@pedrobaeza