Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[17.0][MIG] account_loan: Migration to 17.0 #1960

Merged
merged 64 commits into from
Nov 4, 2024
Merged

[17.0][MIG] account_loan: Migration to 17.0 #1960

merged 64 commits into from
Nov 4, 2024

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Nov 4, 2024 •
edited
Loading

Supersedes #1925

Migration to 17.0

Changes done:

  • Purge translation files
  • Remove unnecessary readonly=true to some fields (fields defining the readonly in the view and/or related)
  • Remove unnecesary default=false to boolean fields (redundant, is the default behavior)
  • Remove unnecessary or text from views
  • Improve multi-company rule + migration script
  • Improve tests

Please @pedrobaeza and @pilarvargas-tecnativa can you review it?

@Tecnativa TT51502

etobella and others added 30 commits October 30, 2024 14:39
@etobella @victoralmau
[ADD] account_loan
23ef652 
OCA Transbot updated translations from Transifex

[UPD] Update account_loan.pot
@jcoux @victoralmau
[11.0][account_loan] Change logger level on import dependency
133e9c8 
According to the guidelines:
https://github.com/OCA/maintainer-tools/blob/master/CONTRIBUTING.md#importerror

Change the logger level from `error` to `debug`.
@etobella @victoralmau
[IMP] Account_loan: Add the option to automatically post invoices
c70ce55 
[UPD] Update account_loan.pot
@rafaelbn @victoralmau
Add Loan Type info in README
02892b7 
   Loan types info:
   `APR <https://en.wikipedia.org/wiki/Annual_percentage_rate>`_,
   `EAR <https://en.wikipedia.org/wiki/Effective_interest_rate>`_,
   `Real Rate <https://en.wikipedia.org/wiki/Real_interest_rate>`_.
@rschnapka @victoralmau
Translated using Weblate (German)
abc20f0 
Currently translated at 99.2% (130 of 131 strings)

Translation: account-financial-tools-11.0/account-financial-tools-11.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-11-0/account-financial-tools-11-0-account_loan/de/

Update translation files

Updated by Update PO files to match POT (msgmerge) hook in Weblate.
@victoralmau
[11.0][FIX] ValueError: min() arg is an empty sequence
b76c6dc
@amcor @victoralmau
[MIG] account_loan: Migration to 12.0
b9e7483
@etobella @victoralmau
[IMP] account_loan: Fix rounding issues
fa93281
@etobella @victoralmau
[IMP] account_loan: Add fixed-annuity-begin
9759c7c
@amcor @victoralmau
[FIX] test error on multi action_move_create
afbef36 
[UPD] Update account_loan.pot

[UPD] README.rst
@marylla @victoralmau
Translated using Weblate (German)
553efd2 
Currently translated at 100.0% (133 of 133 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/de/
@oca-transbot @victoralmau
Update translation files
4ad3e4d 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/
@marylla @victoralmau
Translated using Weblate (German)
630c0fd 
Currently translated at 86.1% (142 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/de/
@etobella @victoralmau
Translated using Weblate (Spanish)
2755575 
Currently translated at 100.0% (165 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/es/
@alvarorib @victoralmau
Translated using Weblate (Portuguese)
22b4879 
Currently translated at 57.0% (94 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/pt/
@marylla @victoralmau
Translated using Weblate (German)
172faf2 
Currently translated at 86.1% (142 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/de/
@mliell @victoralmau
Translated using Weblate (Portuguese (Brazil))
34845ab 
Currently translated at 24.8% (41 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/pt_BR/
@sysadminmatmoz @victoralmau
Translated using Weblate (Slovenian)
cfd5e71 
Currently translated at 13.9% (23 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/sl/
@oca-transbot @victoralmau
Update translation files
826f296 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/
@marcelsavegnago @victoralmau
Translated using Weblate (Portuguese (Brazil))
424da1a 
Currently translated at 83.6% (138 of 165 strings)

Translation: account-financial-tools-12.0/account-financial-tools-12.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-12-0/account-financial-tools-12-0-account_loan/pt_BR/
@albariera @victoralmau
[IMP] account_loan: black,isort,prettier
f91d710
@albariera @victoralmau
[MIG] account_loan: Migration to 13.0
35efc16 
Co-authored-by: Enric Tobella <[email protected]>

[UPD] Update account_loan.pot

[UPD] README.rst
@joao-p-marques @victoralmau
[IMP] *: pre-commit execution
f76126a
@victoralmau
[MIG] account_loan: Migration to 14.0
a07fa93 
[UPD] Update account_loan.pot

[UPD] README.rst
@cubells @victoralmau
[FIX] account_loan: missing acl line
68242eb
@MiquelRForgeFlow @victoralmau
[FIX] account_loan: post() -> action_post()
adb00d4 
account_loan 14.0.1.0.1

account_loan 14.0.1.0.2
@francesco-ooops @victoralmau
Translated using Weblate (Italian)
9b25106 
Currently translated at 9.0% (15 of 165 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/it/
@SicurSam @victoralmau
Translated using Weblate (Italian)
fff23ea 
Currently translated at 45.4% (75 of 165 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/it/
@douglascstd @victoralmau
Translated using Weblate (Portuguese (Brazil))
99a48e8 
Currently translated at 83.6% (138 of 165 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/pt_BR/
@mymage @victoralmau
Translated using Weblate (Italian)
4693bb6 
Currently translated at 100.0% (165 of 165 strings)

Translation: account-financial-tools-14.0/account-financial-tools-14.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-14-0/account-financial-tools-14-0-account_loan/it/
mymage and others added 5 commits October 30, 2024 14:40
@mymage @victoralmau
Translated using Weblate (Italian)
c1b1e22 
Currently translated at 100.0% (175 of 175 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_loan/it/
@SottomaiorMacedoTec @victoralmau
Translated using Weblate (Portuguese (Brazil))
c4e0e5b 
Currently translated at 73.1% (128 of 175 strings)

Translation: account-financial-tools-16.0/account-financial-tools-16.0-account_loan
Translate-URL: https://translation.odoo-community.org/projects/account-financial-tools-16-0/account-financial-tools-16-0-account_loan/pt_BR/
@etobella @victoralmau
[FIX] account_loan: Set name on line in order to make it compatible w…
3358c42 
…ith assets

[BOT] post-merge updates
@victoralmau
[IMP] account_loan: pre-commit auto fixes
0934587
@JT-Odoo @victoralmau
[MIG] account_loan: Migration to 17.0
539827a
@victoralmau victoralmau mentioned this pull request Nov 4, 2024
Closed
@pedrobaeza
Copy link
Member

/ocabot migration account_loan

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone Nov 4, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Nov 4, 2024
Open
33 tasks
@victoralmau victoralmau force-pushed the 17.0-mig-account_loan branch from a83451a to 058323b Compare November 4, 2024 07:53
@victoralmau victoralmau force-pushed the 17.0-mig-account_loan branch from 058323b to a61bd67 Compare November 4, 2024 09:54
@victoralmau
[MIG] account_loan: Finish migration to 17.0
4a63616 
Changes done:
- Purge translation files
- Remove unnecessary readonly=true to some fields (fields defining the readonly in the view and/or related)
- Remove unnecesary default=false to boolean fields (redundant, is the default behavior)
- Remove unnecessary 'or' text from views
- Improve multi-company rule + migration script
- Improve tests

TT51502
@victoralmau victoralmau force-pushed the 17.0-mig-account_loan branch from a61bd67 to 4a63616 Compare November 4, 2024 10:51
pedrobaeza
pedrobaeza approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 17.0-ocabot-merge-pr-1960-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 176febc into OCA:17.0 Nov 4, 2024
11 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 725f07d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-account_loan branch November 4, 2024 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@pilarvargas-tecnativa pilarvargas-tecnativa pilarvargas-tecnativa approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
17.0
Development

Successfully merging this pull request may close these issues.