[17.0][MIG] account_netting: Migration to 17.0

account_netting/README.rst

@@ -85,6 +85,7 @@ Contributors
    -  Pedro M. Baeza
    -  Vicent Cubells
    -  Víctor Martínez
+   -  Marwan Behillil
 
 Maintainers
 -----------

account_netting/__manifest__.py

@@ -4,7 +4,7 @@
 
 {
     "name": "Account netting",
-    "version": "16.0.1.0.0",
+    "version": "17.0.1.0.0",
     "summary": "Compensate AR/AP accounts from the same partner",
     "category": "Accounting & Finance",
     "author": "Tecnativa, Odoo Community Association (OCA)",

account_netting/readme/CONTRIBUTORS.md

@@ -2,3 +2,4 @@
   - Pedro M. Baeza
   - Vicent Cubells
   - Víctor Martínez
+  - Marwan Behillil

account_netting/security/ir.model.access.csv

@@ -1,2 +1,3 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_account_move_make_netting,Full access on account.move.make.netting to accountant grp,model_account_move_make_netting,account.group_account_user,1,1,1,1
+access_account_move_make_netting_manager,Full access on account.move.make.netting to accountant manager grp,model_account_move_make_netting,account.group_account_manager,1,1,1,1

account_netting/static/description/index.html

@@ -427,6 +427,7 @@ <h2><a class="toc-backref" href="#toc-entry-5">Contributors</a></h2>
 <li>Pedro M. Baeza</li>
 <li>Vicent Cubells</li>
 <li>Víctor Martínez</li>
+<li>Marwan Behillil</li>
 </ul>
 </li>
 </ul>

account_netting/wizards/account_move_make_netting.py

@@ -46,7 +46,7 @@
                 "liability_payable",
                 "asset_receivable",
             ):
                 raise UserError(
                     _(
                         "Line '%(line)s' has account '%(account)s' which is not "
                         "a payable nor a receivable account."
@@ -61,7 +61,7 @@
                     _("Line '%s' is already reconciled.") % line.display_name
                 )
             if not line.partner_id:
                 raise UserError(
                     _("Line '%s' doesn't have a partner.") % line.display_name
                 )
             partners |= line.partner_id
@@ -162,7 +162,7 @@
         # Make reconciliation
         for move_line in move.line_ids:
             to_reconcile = move_line + self.move_line_ids.filtered(
-                lambda x: x.account_id == move_line.account_id
+                lambda x, move_line=move_line: x.account_id == move_line.account_id
             )
             to_reconcile.reconcile()
         # Open created move

account_netting/wizards/account_move_make_netting_view.xml

@@ -21,10 +21,7 @@
                     <field name="company_currency_id" invisible="1" />
                     <field name="partner_id" />
                     <field name="balance" />
-                    <field
-                        name="balance_type"
-                        attrs="{'invisible': [('balance', '=', 0)]}"
-                    />
+                    <field name="balance_type" invisible="balance == 0" />
                     <field name="journal_id" />
                 </group>
                 <footer>