Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double-quotes around literal field values #102

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Double-quotes around literal field values #102

merged 2 commits into from
Dec 20, 2023

Conversation

ralfhandl
Copy link
Collaborator

Literal field values are in most places surrounded with double-quotes as "xxx".

kevin-postman
kevin-postman approved these changes Dec 1, 2023
View reviewed changes
Copy link

@kevin-postman kevin-postman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but I believe:
498: ... When used with retry, context transfers back upon completion of the specified workflow.
retry there should also have quotes?
and 499 ALSO has a retry without the "".
If so please add and LGTM

@ralfhandl
Copy link
Collaborator Author

@kevin-postman Thanks, added those two places. Hope we got all now.

@frankkilcommins frankkilcommins merged commit 8447e12 into OAI:main Dec 20, 2023
@ralfhandl ralfhandl deleted the patch-9 branch December 20, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-postman kevin-postman kevin-postman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ralfhandl @kevin-postman @frankkilcommins