Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against ember-concurrency@v3 #868

Merged
merged 10 commits into from
Apr 24, 2023

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Apr 24, 2023

ember-concurrency has gone through a lot of weird changes the past couple years.
Only way to make this sane is to have ember-concurrency tested in its own app (twice, once for v2 and once for v3)

@changeset-bot
Copy link

changeset-bot bot commented Apr 24, 2023

🦋 Changeset detected

Latest commit: c09cabc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2023

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 18.79 kB 3.35 kB 1.36 kB 1.19 kB
├── core/class-based/index.js 8.38 kB 1.88 kB 929 B 798 B
├── core/function-based/index.js 6.9 kB 576 B 269 B 215 B
└── core/use.js 2.91 kB 415 B 256 B 203 B
/link.js 2.67 kB 380 B 234 B 186 B
/service.js 12.94 kB 2.13 kB 1 kB 862 B
/util/cell.js 2.46 kB 917 B 434 B 366 B
/util/debounce.js 2.71 kB 837 B 430 B 352 B
/util/ember-concurrency.js 4.75 kB 1.59 kB 754 B 644 B
/util/fps.js 2.47 kB 904 B 469 B 375 B
/util/function.js 7.66 kB 2.72 kB 996 B 855 B
/util/helper.js 1.79 kB 303 B 218 B 177 B
/util/keep-latest.js 1.75 kB 512 B 296 B 235 B
/util/map.js 5.67 kB 2.5 kB 1.11 kB 939 B
/util/remote-data.js 7.33 kB 2.38 kB 798 B 697 B

@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2023

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review April 24, 2023 23:42
@NullVoxPopuli NullVoxPopuli merged commit b6f78c9 into main Apr 24, 2023
@NullVoxPopuli NullVoxPopuli deleted the is-ember-concurrency-v3-supported branch April 24, 2023 23:42
@github-actions github-actions bot mentioned this pull request Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant