chore(deps): update dependency ember-async-data to v1 - autoclosed #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
|
|
Estimated impact to a consuming app, depending on which bundle is imported
|
Preview URLsreadme: https://54d44063.ember-resources.pages.dev |
renovate
bot
force-pushed
the
renovate/ember-async-data-1.x
branch
2 times, most recently
from
c1e3040 to
1fa9895
Compare
renovate
bot
force-pushed
the
renovate/ember-async-data-1.x
branch
from
1fa9895 to
f5fdc5c
Compare
renovate
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
^0.7.0->^1.0.0Release Notes
chriskrycho/ember-async-data
v1.0.1Compare Source
Note: This is a significant bug fix which does (very mildly) break the public API, but necessarily so for the sake of fixing a bug.
🐛 Bug Fix
#578 Bugfix: drop
contextand stop cachingTrackedAsyncData(@chriskrycho)Previously,
TrackedAsyncDataand theloadfunction accepted acontextparameter as their second argument, to use with Ember's destroyables API. However, that was (a) unnecessary and (b) could actually cause memory leaks, literally the opposite of what it was designed to do. To account for this change, simply remove that call from all call sites.Additionally, note that this means that you will no longer get a single instance of
TrackedAsyncDatafor the same promise. In most cases, this is irrelevant, and it is likely that removing our cache which attempted to be helpful that way will improve your performance.Committers: 1
v1.0.0Compare Source
💥 Breaking Change
🚀 Enhancement
📝 Documentation
TrackedPromisein Readme (@simonihmig)🏠 Internal
16 || >= 18in test app engines (@chriskrycho)Committers: 5
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.