Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved glint support with gts / <template> #603

Merged
merged 5 commits into from
Aug 28, 2022
Merged

Improved glint support with gts / <template> #603

merged 5 commits into from
Aug 28, 2022

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Aug 27, 2022 •
edited
Loading

I tried to also get some better types for from (so that they infer the args for the particular class) -- that'll probably have to be another PR though.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Aug 27, 2022 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6e4c9b
Status: ✅  Deploy successful!
Preview URL: https://7625f67e.ember-resources.pages.dev
Branch Preview URL: https://improved-glint-support.ember-resources.pages.dev

View logs

@github-actions
Copy link
Contributor

github-actions bot commented Aug 27, 2022 •
edited
Loading

Estimated impact to a consuming app, depending on which bundle is imported

js min min + gzip min + brotli
/index.js 13.76 kB 3.25 kB 1.34 kB 1.18 kB
├── core/class-based/index.js 4.45 kB 1.89 kB 933 B 796 B
├── core/function-based/index.js 6 kB 552 B 269 B 213 B
└── core/use.js 2.91 kB 415 B 256 B 203 B
/util/cell.js 1.99 kB 800 B 410 B 346 B
/util/debounce.js 2.64 kB 771 B 408 B 340 B
/util/ember-concurrency.js 4.35 kB 1.53 kB 733 B 624 B
/util/function-resource.js 216 B 154 B 123 B 87 B
/util/function.js 4.03 kB 1.78 kB 703 B 595 B
/util/helper.js 1.8 kB 303 B 218 B 177 B
/util/keep-latest.js 1.75 kB 519 B 292 B 236 B
/util/map.js 5.66 kB 2.38 kB 993 B 847 B
/util/remote-data.js 4.86 kB 1.75 kB 674 B 593 B

@NullVoxPopuli
feat(@use): now works with class-based resources
0803f1f 
This is in part, striving for consistency among all APIs.
The goal is to have all APIs available in "the 3 contexts":
 - with `@use`
 - without `@use` (passing a `this`)
 - direct usage in the template
@NullVoxPopuli NullVoxPopuli force-pushed the improved-glint-support branch from f033586 to 0803f1f Compare August 28, 2022 01:41
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review August 28, 2022 22:25
@NullVoxPopuli NullVoxPopuli merged commit 6774c1e into main Aug 28, 2022
@NullVoxPopuli NullVoxPopuli deleted the improved-glint-support branch August 28, 2022 22:25
@github-actions
Copy link
Contributor

🎉 This PR is included in version 5.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot mentioned this pull request Jun 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NullVoxPopuli