Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert to V2 Addon #263

Merged
merged 16 commits into from
Oct 31, 2021
Merged

Convert to V2 Addon #263

merged 16 commits into from
Oct 31, 2021

Conversation

NullVoxPopuli
Copy link
Owner

@NullVoxPopuli NullVoxPopuli commented Oct 31, 2021

  • Convert to V2 Addon
  • Ensure eslint-configs supports V2 Addons
  • Move tests to test app
  • Make sure tests still pass in new test app
  • Update test scenarios / try config
  • Update C.I. for new paths

Issues Encountered:

  • ember cli does not support ESM
    • (moving to ESM would be a breaking change)-
  • @embroider/addon-dev (+ supporting docs) does not support typescript out of the box
  • @ember/test-waiters needed to be excluded + moved to peerDependencies
    • before this was done, we had two separate copies of @ember/test-waiters, meaning waitForPromise (used in the FunctionRunner), was register different waiters from what the host app was aware of -- hopefully there is some dependency lint tool to catch this in the future

@NullVoxPopuli NullVoxPopuli force-pushed the v2-addon branch 2 times, most recently from db6326a to 1f3076b Compare October 31, 2021 02:37
@NullVoxPopuli NullVoxPopuli merged commit 7198993 into main Oct 31, 2021
@NullVoxPopuli NullVoxPopuli deleted the v2-addon branch October 31, 2021 21:36
@github-actions
Copy link
Contributor

🎉 This PR is included in version 3.2.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant