de-mystify resource internals #1166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Estimated impact to a consuming app, depending on which bundle is imported
|
is thish better? maybe tests will tell me ope ope The builder had to be registered to the helper manager Be more robust with owner detection Maybe progress it works, now for memory leak testing
NullVoxPopuli
force-pushed
the
make-the-return-the-value-public-api
branch
from
8e74bcd to
2400805
Compare
NullVoxPopuli
commented
Jan 10, 2025
| test('a generated interval can be cleared', async function (assert) { | ||
| const id = cell(0); | ||
| const condition = cell(true); | ||
|
|
||
| const poll = resourceFactory((id: number) => { |
There was a problem hiding this comment.
resourceFactory isn't needed here, and is kinda awkward to have inline like this (moreso that the call below, imo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.