Add separate test app for testing old TS types (TS < 5.1)

.github/workflows/ci.yml

@@ -53,7 +53,7 @@ jobs:
       - uses: ./.github/actions/assert-build
 
 
-  typecheck:
+  typecheck_legacy:
     name: '${{ matrix.typescript-scenario }}'
     runs-on: ubuntu-latest
     timeout-minutes: 5
@@ -66,9 +66,50 @@ jobs:
           - [email protected]
           - [email protected]
           - [email protected]
+
+    steps:
+      - uses: actions/checkout@v4
+      - uses: wyvox/action-setup-pnpm@v3
+        with:
+          node-version: 18.18.1
+      - name: 'Build'
+        run: pnpm build
+      - name: 'Change TS to ${{ matrix.typescript-scenario }}'
+        run: 'pnpm add --save-dev ${{ matrix.typescript-scenario}}'
+        working-directory: ./test-app
+
+      # This has been really annoying
+      # due to injected dependencies :(
+      - name: 'Re-sync injected dependencies'
+        run: pnpm i -f
+      - name: 'Print Versions'
+        run: |
+          pnpm --filter "test-app*" exec tsc -v;
+          pnpm --filter "test-app*" exec glint --version;
+
+      - name: 'Type checking (built in types)'
+        run: pnpm --filter "test-app-old-ts" exec glint;
+
+      # - name: 'Type checking (DefinitelyTyped types)'
+      #   run: pnpm --filter "test-app-definitely-typed" exec glint;
+
+  typecheck:
+    name: '${{ matrix.typescript-scenario }}'
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    needs: [build]
+    continue-on-error: true
+    strategy:
+      fail-fast: true
+      matrix:
+        typescript-scenario:
           - [email protected]
           - [email protected]
           - [email protected]
+          - [email protected]
+          - [email protected]
+          - [email protected]
+          - [email protected]
 
     steps:
       - uses: actions/checkout@v4
@@ -90,9 +131,6 @@ jobs:
           pnpm --filter "test-app*" exec tsc -v;
           pnpm --filter "test-app*" exec glint --version;
 
-        # Types of newer versions are not compatible with TS < v5
-      - run: pnpm add --save-dev "@ember/test-helpers@^3.0.0"
-        working-directory: 'test-app'
       - name: 'Type checking (built in types)'
         run: pnpm --filter "test-app" exec glint;
 

pnpm-workspace.yaml

@@ -3,5 +3,6 @@ packages:
   - "codemod"
   - "docs"
   - "test-app"
+  - "test-app-old-ts"
   - "test-app-definitely-typed"
   - "dev/*"

test-app-old-ts/.editorconfig

@@ -0,0 +1,19 @@
+# EditorConfig helps developers define and maintain consistent
+# coding styles between different editors and IDEs
+# editorconfig.org
+
+root = true
+
+[*]
+end_of_line = lf
+charset = utf-8
+trim_trailing_whitespace = true
+insert_final_newline = true
+indent_style = space
+indent_size = 2
+
+[*.hbs]
+insert_final_newline = false
+
+[*.{diff,md}]
+trim_trailing_whitespace = false

test-app-old-ts/.ember-cli

@@ -0,0 +1,9 @@
+{
+  /**
+    Ember CLI sends analytics information by default. The data is completely
+    anonymous, but there are times when you might want to disable this behavior.
+
+    Setting `disableAnalytics` to true will prevent any data from being sent.
+  */
+  "disableAnalytics": false
+}

test-app-old-ts/.eslintignore

@@ -0,0 +1,23 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+/public/
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+.*/
+.eslintcache
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

test-app-old-ts/.eslintrc.js

@@ -0,0 +1,54 @@
+'use strict';
+
+const { configs } = require('@nullvoxpopuli/eslint-configs');
+
+const config = configs.ember();
+
+module.exports = {
+  ...config,
+  overrides: [
+    ...config.overrides,
+    {
+      files: ['**/*.gts'],
+      plugins: ['ember'],
+      parser: 'ember-eslint-parser',
+      globals: {
+        // used in testing as a shorthand for <output>
+        out: true,
+      },
+    },
+    {
+      files: ['**/*.gjs'],
+      plugins: ['ember'],
+      parser: 'ember-eslint-parser',
+    },
+    {
+      files: ['**/*.{ts,gts}'],
+      rules: {
+        /**
+         * This one is incorrectly parsed for now, because
+         * the rule doesn't understand decorators
+         */
+        '@typescript-eslint/no-unused-vars': 'off',
+
+        /**
+         * any can be useful
+         */
+        '@typescript-eslint/no-explicit-any': 'off',
+
+        /**
+         * Some compiler errors are not helpful
+         */
+        '@typescript-eslint/ban-ts-comment': [
+          'error',
+          {
+            'ts-ignore': 'allow-with-description',
+            'ts-nocheck': 'allow-with-description',
+            'ts-check': 'allow-with-description',
+            'ts-expect-error': 'allow-with-description',
+          },
+        ],
+      },
+    },
+  ],
+};

test-app-old-ts/.gitignore

@@ -0,0 +1,26 @@
+# See https://help.github.com/ignore-files/ for more about ignoring files.
+
+# compiled output
+/dist/
+/tmp/
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/.env*
+/.pnp*
+/.sass-cache
+/.eslintcache
+/connect.lock
+/coverage/
+/libpeerconnection.log
+/npm-debug.log*
+/testem.log
+/yarn-error.log
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

test-app-old-ts/.prettierignore

@@ -0,0 +1,26 @@
+# unconventional js
+/blueprints/*/files/
+/vendor/
+/public/
+*.yaml
+*.md
+*.yml
+
+# compiled output
+/dist/
+/tmp/
+CHANGELOG.md
+
+# dependencies
+/bower_components/
+/node_modules/
+
+# misc
+/coverage/
+!.*
+.eslintcache
+
+# ember-try
+/.node_modules.ember-try/
+/bower.json.ember-try
+/package.json.ember-try

test-app-old-ts/.prettierrc.js

@@ -0,0 +1,30 @@
+'use strict';
+
+module.exports = {
+  plugins: ['prettier-plugin-ember-template-tag'],
+  printWidth: 100,
+  singleQuote: true,
+  templateSingleQuote: false,
+  // this was required to make the VSCode + Prettier work correctly with <template>, see https://github.com/gitKrystan/prettier-plugin-ember-template-tag/issues/38
+  // we should roll this back once that issue has been fixed!
+  overrides: [
+    {
+      files: '*.hbs',
+      options: {
+        singleQuote: false,
+      },
+    },
+    {
+      files: '*.gjs',
+      options: {
+        parser: 'ember-template-tag',
+      },
+    },
+    {
+      files: '*.gts',
+      options: {
+        parser: 'ember-template-tag',
+      },
+    },
+  ],
+};

test-app-old-ts/.template-lintrc.js

@@ -0,0 +1,14 @@
+'use strict';
+
+module.exports = {
+  extends: 'recommended',
+  overrides: [
+    {
+      files: ['**/*.gjs', '**/*.gts'],
+      rules: {
+        'no-curly-component-invocation': 'off',
+        'no-implicit-this': 'off',
+      },
+    },
+  ],
+};

test-app-old-ts/.watchmanconfig

@@ -0,0 +1,3 @@
+{
+  "ignore_dirs": ["tmp", "dist"]
+}

test-app-old-ts/app

@@ -0,0 +1 @@
+../test-app/app/

test-app-old-ts/config/dependency-lint.js

@@ -0,0 +1,3 @@
+'use strict';
+
+module.exports = {};

test-app-old-ts/config/deprecation-workflow.js

@@ -0,0 +1,6 @@
+/* eslint-disable no-undef */
+self.deprecationWorkflow = self.deprecationWorkflow || {};
+self.deprecationWorkflow.config = {
+  throwOnUnhandled: true,
+  workflow: [],
+};

test-app-old-ts/config/ember-cli-update.json

@@ -0,0 +1,18 @@
+{
+  "schemaVersion": "1.0.0",
+  "packages": [
+    {
+      "name": "ember-cli",
+      "version": "3.28.3",
+      "blueprints": [
+        {
+          "name": "app",
+          "outputRepo": "https://github.com/ember-cli/ember-new-output",
+          "codemodsSource": "ember-app-codemods-manifest@1",
+          "isBaseBlueprint": true,
+          "options": ["--yarn"]
+        }
+      ]
+    }
+  ]
+}