Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #599

Merged
merged 5 commits into from
Feb 1, 2025
Merged

Cleanup #599

merged 5 commits into from
Feb 1, 2025

Conversation

Nukesor
Copy link
Owner

@Nukesor Nukesor commented Feb 1, 2025

No description provided.

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 80.68%. Comparing base (fbca708) to head (17672ea).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pueue/src/daemon/state_helper.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #599      +/-   ##
==========================================
+ Coverage   79.22%   80.68%   +1.46%     
==========================================
  Files          74       74              
  Lines        5940     5872      -68     
==========================================
+ Hits         4706     4738      +32     
+ Misses       1234     1134     -100     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 1, 2025

Test Results

  3 files  ± 0   19 suites  ±0   3m 21s ⏱️ +9s
171 tests + 8  171 ✅ + 8  0 💤 ±0  0 ❌ ±0 
360 runs  +16  360 ✅ +16  0 💤 ±0  0 ❌ ±0 

Results for commit 17672ea. ± Comparison against base commit fbca708.

This pull request removes 6 and adds 14 tests. Note that renamed tests count towards both.
pueue::tests ‑ client::integration::completions::autocompletion_generation::case_1
pueue::tests ‑ client::integration::completions::autocompletion_generation::case_2
pueue::tests ‑ client::integration::completions::autocompletion_generation::case_3
pueue::tests ‑ client::integration::completions::autocompletion_generation::case_4
pueue::tests ‑ client::integration::completions::autocompletion_generation::case_5
pueue::tests ‑ client::integration::completions::autocompletion_generation::case_6
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_file::case_1
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_file::case_2
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_file::case_3
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_file::case_4
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_file::case_5
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_file::case_6
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_stdout::case_1
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_stdout::case_2
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_stdout::case_3
pueue::tests ‑ client::integration::completions::autocompletion_generation_to_stdout::case_4
…

♻️ This comment has been updated with latest results.

@Nukesor Nukesor self-assigned this Feb 1, 2025
@Nukesor Nukesor merged commit 096b796 into main Feb 1, 2025
19 checks passed
@Nukesor Nukesor deleted the cleanup branch February 1, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant