Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localization API #64

Merged
merged 25 commits into from
Oct 23, 2022
Merged

Add localization API #64

merged 25 commits into from
Oct 23, 2022

Conversation

Alexejhero
Copy link
Member

@Alexejhero Alexejhero commented Oct 7, 2022 •
edited
Loading

Changes in this pull request

  • This pull request adds an API which allows mods to easily create and add custom translations
  • The old CustomStringName API has been modified (breaking change)
  • Examples are present in the reactor example plugin

@js6pak js6pak changed the base branch from v2 to master October 9, 2022 20:02
@Alexejhero Alexejhero marked this pull request as ready for review October 10, 2022 15:51
js6pak
js6pak requested changes Oct 13, 2022
View reviewed changes
Reactor/Localization/Providers/HardCodedLocalizationProvider.cs Outdated Show resolved Hide resolved
Reactor/Localization/Providers/HardCodedLocalizationProvider.cs Outdated Show resolved Hide resolved
Reactor.Example/ExamplePlugin.cs Outdated Show resolved Hide resolved
Reactor/Localization/LocalizationManager.cs Outdated Show resolved Hide resolved
@Alexejhero Alexejhero requested a review from js6pak October 13, 2022 15:54
@js6pak js6pak merged commit 0c8156a into NuclearPowered:master Oct 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@js6pak js6pak js6pak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Alexejhero @js6pak