-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test for resolving versions when updating in a diamond dependency graph #11
Conversation
… a diamond dependency graph that requires multiple package updates (scenario failing on NuGet 2.8.5)
Thanks@mrahl I'm assuming this test is passing :) I'm closing and re-opening for you to sign a CLA, a robot will take over from here. |
Hi @mrahl, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution! TTYL, DNFBOT; |
@mrahl I'll merge this in once you sign the CLA. Thanks! |
Sorry for the delay, I have to run the agreement by our legal department. |
@mrahl ping |
@mrahl we can't take this contribution without a CLA, do you intend to sign one? |
I know I know... Still haven't got an OK from legal/managers. I'm going to give it one last go tomorrow, otherwise I'll close the PR myself. |
No worries, this thread have jus gone silent. We are ok with waiting |
@mrahl we cannot take this pull request without a CLA. Is it going to happen? |
I finally got this sorted out, I just need a couple more days to get some formal record of the approval. Thank you for your patience. It will be alot easier the next time me or anyone else from the company makes a contribution. |
@mrahl, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
We should take this for 3.3 |
Closed with NuGet/NuGet.Client#26 |
As discussed in issue 423 - Added test for resolving versions when updating dependency package in a diamond dependency graph that requires multiple package updates (scenario failing on NuGet 2.8.5).