Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test for resolving versions when updating in a diamond dependency graph #11

Closed
wants to merge 1 commit into from

Conversation

mrahl
Copy link

@mrahl mrahl commented May 5, 2015

As discussed in issue 423 - Added test for resolving versions when updating dependency package in a diamond dependency graph that requires multiple package updates (scenario failing on NuGet 2.8.5).

… a diamond dependency graph that requires multiple package updates (scenario failing on NuGet 2.8.5)
@yishaigalatzer
Copy link

Thanks@mrahl I'm assuming this test is passing :)

I'm closing and re-opening for you to sign a CLA, a robot will take over from here.

@dnfclas
Copy link

dnfclas commented May 12, 2015

Hi @mrahl, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!

In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla2.dotnetfoundation.org.

TTYL, DNFBOT;

@emgarten
Copy link
Contributor

@mrahl I'll merge this in once you sign the CLA. Thanks!

@mrahl
Copy link
Author

mrahl commented May 18, 2015

Sorry for the delay, I have to run the agreement by our legal department.

@yishaigalatzer
Copy link

@mrahl ping

@yishaigalatzer
Copy link

@mrahl we can't take this contribution without a CLA, do you intend to sign one?

@mrahl
Copy link
Author

mrahl commented Jun 15, 2015

I know I know... Still haven't got an OK from legal/managers. I'm going to give it one last go tomorrow, otherwise I'll close the PR myself.

@yishaigalatzer
Copy link

No worries, this thread have jus gone silent. We are ok with waiting

@yishaigalatzer
Copy link

@mrahl we cannot take this pull request without a CLA. Is it going to happen?

@mrahl
Copy link
Author

mrahl commented Aug 17, 2015

I finally got this sorted out, I just need a couple more days to get some formal record of the approval. Thank you for your patience. It will be alot easier the next time me or anyone else from the company makes a contribution.

@dnfclas
Copy link

dnfclas commented Aug 19, 2015

@mrahl, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.

Thanks, DNFBOT;

@yishaigalatzer
Copy link

We should take this for 3.3

@deepakaravindr
Copy link
Contributor

Closed with NuGet/NuGet.Client#26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants