[TFM Display] Add feature flag to display TFM. #8867
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loic-sharma
reviewed
Nov 8, 2021
| @@ -52,6 +52,7 @@ public class FeatureFlagService : IFeatureFlagService | |||
| private const string DisplayPackagePageV2PreviewFeatureName = GalleryPrefix + "DisplayPackagePageV2Preview"; | |||
| private const string DisplayPackagePageV2FeatureName = GalleryPrefix + "DisplayPackagePageV2"; | |||
| private const string ShowReportAbuseSafetyChanges = GalleryPrefix + "ShowReportAbuseSafetyChanges"; | |||
| private const string DisplayTFMFeatureName = GalleryPrefix + "DisplayTFM"; | |||
There was a problem hiding this comment.
Please change TFM to Tfm everywhere. .NET's naming guideline is to pascal case acronyms longer than two characters: https://docs.microsoft.com/en-us/dotnet/standard/design-guidelines/capitalization-conventions#capitalization-rules-for-identifiers
There was a problem hiding this comment.
What do you think of using the term TargetFramework instead of TFM? This may be clearer to folks. For example:
Suggested change
| private const string DisplayTFMFeatureName = GalleryPrefix + "DisplayTFM"; | |
| private const string DisplayTargetFrameworkFeatureName = GalleryPrefix + "DisplayTargetFramework"; |
loic-sharma
approved these changes
Nov 8, 2021
| @@ -52,6 +52,7 @@ public class FeatureFlagService : IFeatureFlagService | |||
| private const string DisplayPackagePageV2PreviewFeatureName = GalleryPrefix + "DisplayPackagePageV2Preview"; | |||
| private const string DisplayPackagePageV2FeatureName = GalleryPrefix + "DisplayPackagePageV2"; | |||
| private const string ShowReportAbuseSafetyChanges = GalleryPrefix + "ShowReportAbuseSafetyChanges"; | |||
| private const string DisplayTFMFeatureName = GalleryPrefix + "DisplayTFM"; | |||
There was a problem hiding this comment.
What do you think of using the term TargetFramework instead of TFM? This may be clearer to folks. For example:
Suggested change
| private const string DisplayTFMFeatureName = GalleryPrefix + "DisplayTFM"; | |
| private const string DisplayTargetFrameworkFeatureName = GalleryPrefix + "DisplayTargetFramework"; |
lyndaidaii
approved these changes
Nov 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.