Separate Description on Gallery like it was specified in the NuSpec #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke release notes do.
| @@ -66,7 +66,10 @@ | |||
| <h1>@Model.Title</h1> | |||
| <h2>@Model.Version</h2> | |||
| </hgroup> | |||
| <p>@Model.Description</p> | |||
| @foreach (var line in Model.Description.Split('\n')) | |||
There was a problem hiding this comment.
This will throw if Description is null on the model coming out of EF. Maybe .ToStringSafe().Split() instead? Or wrap it in a IsNull check like we do with release notes?
There was a problem hiding this comment.
I think I missed the is null bits in my first look down there. Description is a required element but it could be empty. Let me update...
There was a problem hiding this comment.
Yeah, we require it now, but on the old gallery you could push a package without it, and there are packages in the database with null descriptions. :(
half-ogre
added a commit
that referenced
this pull request
Jun 14, 2012
Separate Description on Gallery like it was specified in the NuSpec
joelverhagen
pushed a commit
that referenced
this pull request
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same behavior that has been implemented for the release notes section.
An example here:
Without splitting the description into lines: http://nuget.org/packages/chocolatey
With the description split: http://chocolatey.org/packages/chocolatey
Of course that description can now get some cleanup since there is no need to separate sections with || anymore.