This repository was archived by the owner on Mar 16, 2021. It is now read-only.
Add deprecation metadata to registration when it is present in catalog #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scottbommarito
requested review from
joelverhagen,
agr,
loic-sharma,
xavierdecoster,
shishirx34,
nugetlurker,
ryuyu,
cristinamanum,
skofman1,
dannyjdev,
zhhyu and
mogah
|
Can we have some unit tests that assert the actual JSON shape in the deprecated an non deprecated cases? |
|
|
|
@joelverhagen - I found some tests (written by @dtivel) that I can add to--stay tuned! |
added 3 commits
May 20, 2019 14:31
|
@joelverhagen - I finished writing the tests and also caught a bug in the process. It's ready for reviews again! |
tests/CatalogTests/Helpers/RegistrationPackageDeprecationDetails.cs
Outdated
Show resolved
Hide resolved
joelverhagen
approved these changes
May 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/nuget/engineering/issues/2384