Add route to match older Nuget.Server uploads

[ericcoleman]

Between NuGet.Server v2.8.50926.602 and NuGet.Server v3.1.2.0 the route to push a package was changed from /api/v2/packages to /nuget.

When using nuget.exe, if using the root url it will append api/v2/packages.
For example,

.\Nuget.exe push "{thing}.nupkg" -s http://localhost:40221 -Verbosity detailed
Pushing {package} 1.2.3 to 'http://localhost:40221'...
PUT http://localhost:40221/api/v2/package/

This change will allow users to continue to push packages to api/v2/packages so they don't have to edit their existing deployment scripts when doing a Nuget.Server upgrade.

[shishirx34]

Not sure why the upload route was changed from api/v2/package to root/ @joelverhagen - thoughts?

[ericcoleman]

Hey just wanted to follow up on this PR. Any movement?

[chenriksson]

@ericcoleman Sorry for the delay! I'll put this on my agenda for this week and get back to you soon.

[chenriksson]

@ericcoleman I've confirmed the CI gate passes, and will be testing soon. I hope to merge this tomorrow!

[chenriksson]

@shishirx34 The route changed in v3.0.0, as part of the WCF to WebApi changes. Discussed offline with @joelverhagen and we don't see any concern with adding back the original upload route.

[chenriksson]

Verified with build 39095

[Levente0xFFFF]

This change breaks our application. We cannot upgrade from NuGet.Server.V2 3.1.2 to 3.2.0 because of this change. This is a breaking change, so this package should be unlisted and re-released with version 4.0.0. See semver.org for details.

We are getting this exception when calling NuGetV2WebApiEnabler.UseNuGetV2WebApiFeed():

System.ArgumentException: 'A route named 'apiv2package_upload' is already in the route collection. Route names must be unique.
Parameter name: name'

We are hosting multiple NuGet feeds on the same web app and passing the routeName as a parameter.
Since this change hard codes the route name this is not possible anymore:

NuGet.Server/src/NuGet.Server.V2/NuGetV2WebApiEnabler.cs

Line 57 in e5d8ee2

name: "apiv2package_upload",

All the above route registrations are taking the routeName parameter into consideration, but not this one.

[joelverhagen]

@Levente0xFFFF, thanks for the report and we apologise for the inconvenience. Could you open a new GitHub issue so we can track this separately?

It seems like a straightforward fix would be to make this route optional. Do you think a bool parameter to this method would be sufficient to solve your problem?