Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config.props to 17.14 Preview 1 #6213

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

donnie-msft
Copy link
Contributor

@donnie-msft donnie-msft commented Jan 7, 2025

Related: https://github.com/NuGet/Client.Engineering/issues/3128
Update branding in dev branch to 6.14.0-preview.1

@donnie-msft donnie-msft requested a review from a team as a code owner January 7, 2025 21:12
@nkolev92
Copy link
Member

nkolev92 commented Jan 7, 2025

Not necessarily a blocker for this PR since I merged my change, but I'd like to get c4b2619 in as well in the insertion tomorrow.

Please use the branching template, since there's quite a bit to be done beyond just changing the branding: https://github.com/NuGet/Client.Engineering/issues/new?assignees=&labels=Type%3AEngineering%2CPriority%3A2&projects=&template=branch_template.md

@jeffkl jeffkl added the Merge next release PRs that should not be merged until the dev branch targets the next release label Jan 7, 2025
@nkolev92
Copy link
Member

The branching template is supposed to be an issue.

Within it, there's changes that require more than 1 PR (changes to both release and dev branches)

@donnie-msft
Copy link
Contributor Author

The branching template is supposed to be an issue.

@nkolev92 sounds good, I have put this PR back how it was originally and created https://github.com/NuGet/Client.Engineering/issues/3128.

Within it, there's changes that require more than 1 PR (changes to both release and dev branches)

There are multiple PRs I created and linked in that issue. I'm only waiting on them being merged so I can progress through the rest of the checklist.

@donnie-msft donnie-msft requested a review from nkolev92 January 13, 2025 19:06
@donnie-msft donnie-msft merged commit 23ee08f into dev Jan 13, 2025
23 checks passed
@donnie-msft donnie-msft deleted the dev-donnie-msft-config1714Prev1 branch January 13, 2025 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Merge next release PRs that should not be merged until the dev branch targets the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants