simplify some linq expressions #6196
Conversation
microsoft-github-policy-service
bot
added
the
Community
…Count-into-only-Count
SimonCropp
changed the title
|
Changes look good, there's some formatting issues the CI is reporting. |
| Log = logger, | ||
| CacheContext = new SourceCacheContext() | ||
| }; | ||
| var restoreContext = new RestoreArgs() {Sources = new List<string>() {packageSource.FullName}, GlobalPackagesFolder = packagesDir.FullName, Log = logger, CacheContext = new SourceCacheContext()}; |
There was a problem hiding this comment.
I don't like this change, I think it's much easier to read one property per line. It's also unrelated to the title of this PR.
| Log = logger, | ||
| CacheContext = new SourceCacheContext() | ||
| }; | ||
| var restoreContext = new RestoreArgs() {Sources = new List<string>() {packageSource.FullName}, GlobalPackagesFolder = packagesDir.FullName, Log = logger, CacheContext = new SourceCacheContext()}; |
There was a problem hiding this comment.
I don't like this change, I think it's much easier to read one property per line. It's also unrelated to the title of this PR.
| Log = logger, | ||
| CacheContext = new SourceCacheContext() | ||
| }; | ||
| var restoreContext = new RestoreArgs() {Sources = new List<string>() {packageSource.FullName}, GlobalPackagesFolder = packagesDir.FullName, Log = logger, CacheContext = new SourceCacheContext()}; |
There was a problem hiding this comment.
I don't like this change, I think it's much easier to read one property per line. It's also unrelated to the title of this PR.
| Log = logger, | ||
| CacheContext = new SourceCacheContext() | ||
| }; | ||
| var restoreContext = new RestoreArgs() {Sources = new List<string>() {packageSource.FullName}, GlobalPackagesFolder = packagesDir.FullName, Log = logger, CacheContext = new SourceCacheContext()}; |
There was a problem hiding this comment.
I don't like this change, I think it's much easier to read one property per line. It's also unrelated to the title of this PR.
| Log = logger, | ||
| CacheContext = new SourceCacheContext() | ||
| }; | ||
| var restoreContext = new RestoreArgs() {Sources = new List<string>() {packageSource.FullName}, GlobalPackagesFolder = packagesDir.FullName, Log = logger, CacheContext = new SourceCacheContext()}; |
There was a problem hiding this comment.
I don't like this change, I think it's much easier to read one property per line. It's also unrelated to the title of this PR.
|
@SimonCropp do you care if I reopen this PR and push some changes to your branch (assuming your fork allows it) and drive this PR to completion? I think simplification changes are worth merging, and this way you'd get credit for the PR. Otherwise, I'd probably just recreate the PR from my own branch. |
|
@nkolev92 go for it. and i dont need credit. just make the changes in whatever way is easiest for you. I only closed all my PRs since i found the NuGet.Client project to have too much unecessary friction to contribute to |
|
@nkolev92 if u want a look at a MS project that is easier to contribute to see testfx. |
Bug
Fixes:
Description
PR Checklist