Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPVM preview message should be visible at minimal verbosity #3971

Merged
merged 1 commit into from
Mar 29, 2021

Conversation

zivkan
Copy link
Member

@zivkan zivkan commented Mar 26, 2021

Bug

Fixes: NuGet/Home#10226

Regression? no

Description

  1. CPVM preview warning was changed to minimal, rather than "informational" (normal) verbosity
    • This is the same as .NET CLI's preview version warning
  2. Fixed a bug in our VS logger, where minimal verbosity messages were incorrectly being treated as normal verbosity

PR Checklist

  • PR has a meaningful title

  • PR has a linked issue.

  • Described changes

  • Tests

    • Automated tests added
      • RestoreCommand tested via modifying existing test to no longer explicitly use normal verbosity
    • AND
    • Test exception
      • VS RestoreOperationLogger not tested because there are no existing tests for it, it depends on JTF, possibly AsyncServiceProvider, and looks generally difficult to test, which doesn't seem worthwhile given the simplicity of the change made to the production code
  • Documentation
    • N/A

@zivkan zivkan requested a review from a team as a code owner March 26, 2021 19:28
@zivkan zivkan merged commit 87194dd into dev Mar 29, 2021
@zivkan zivkan deleted the dev-zivkan-cpvm-preview-message branch March 29, 2021 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CPVM] preview warning should be shown on dotnet cli
3 participants