Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes https://github.com/NuGet/Home/issues/1157 #19

Closed
wants to merge 1 commit into from
Closed

Fixes https://github.com/NuGet/Home/issues/1157 #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/NuGet.Core/NuGet.Packaging/PackageExtraction/NuGetPackageUtils.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,8 @@ await ConcurrencyUtilities.ExecuteWithFileLocked(targetNupkg,
// Now rename the tmp file
File.Move(targetTempNupkg, targetNupkg);

var tempHashPath = Path.Combine(hashPath, Path.GetRandomFileName());

using (var nupkgStream = File.Open(targetNupkg, FileMode.Open, FileAccess.Read, FileShare.Read))
{
string packageHash;
Expand All @@ -122,7 +124,10 @@ await ConcurrencyUtilities.ExecuteWithFileLocked(targetNupkg,

// Note: PackageRepository relies on the hash file being written out as the
// final operation as part of a package install to assume a package was fully installed.
File.WriteAllText(hashPath, packageHash);
File.WriteAllText(tempHashPath, packageHash);

// Rename the tmp hash file
File.Move(tempHashPath, hashPath);
}

log.LogVerbose($"Completed installation of {packageIdentity.Id} {packageIdentity.Version}");
Expand Down