Merge pull request #590 from papermark/fix/files

NotionX · Nov 21, 2024 · 8d1751e · 8d1751e
2 parents f7cd3d7 + b54f614
commit 8d1751e
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 6 deletions.
diff --git a/packages/react-notion-x/src/components/asset.tsx b/packages/react-notion-x/src/components/asset.tsx
@@ -135,7 +135,9 @@ export function Asset({
   }
 
   if (block.space_id) {
-    source = source.concat('&spaceId=', block.space_id)
+    const url = new URL(source)
+    url.searchParams.set('spaceId', block.space_id)
+    source = url.toString()
   }
 
   let content = null

diff --git a/packages/react-notion-x/src/components/audio.tsx b/packages/react-notion-x/src/components/audio.tsx
@@ -16,14 +16,16 @@ export function Audio({
   let source =
     recordMap.signed_urls[block.id] || block.properties?.source?.[0]?.[0]
 
-  if (block.space_id) {
-    source = source?.concat('&spaceId=', block.space_id)
-  }
-
   if (!source) {
     return null
   }
 
+  if (block.space_id) {
+    const url = new URL(source)
+    url.searchParams.set('spaceId', block.space_id)
+    source = url.toString()
+  }
+
   return (
     <div className={cs('notion-audio', className)}>
       <audio controls preload='none' src={source} />

diff --git a/packages/react-notion-x/src/components/file.tsx b/packages/react-notion-x/src/components/file.tsx
@@ -23,7 +23,9 @@ export function File({
   }
 
   if (block.space_id) {
-    source = source.concat('&spaceId=', block.space_id)
+    const url = new URL(source)
+    url.searchParams.set('spaceId', block.space_id)
+    source = url.toString()
   }
 
   return (