--sd-id param added to *pkg generate* #64
Conversation
nordicsemi/__main__.py
Outdated
| @@ -380,7 +380,13 @@ def pkg(): | |||
| '\n|s132_nrf52_3.0.0|0x8C|' | |||
| '\n|s132_nrf52_3.1.0|0x91|' | |||
| '\n|s132_nrf52_4.0.0|0x95|' | |||
| '\n|s132_nrf52_4.0.2|0x98|', | |||
| '\n|s132_nrf52_4.0.2|0x98|' | |||
| '\n|s140_nrf52840_5.0.0-2.alpha|0x96|', | |||
There was a problem hiding this comment.
There is also 5.0.0-1.alpha and 5.0.0-3.alpha. Should those be added as well?
There was a problem hiding this comment.
Must also remember to update README.md with the new SD versions.
| @@ -152,6 +155,9 @@ def __init__(self, | |||
| filename=app_fw, | |||
| init_packet_data=init_packet_vars) | |||
|
|
|||
| if sd_req is not None: | |||
| init_packet_vars[PacketField.REQUIRED_SOFTDEVICES_ARRAY] = sd_req | |||
There was a problem hiding this comment.
On line 148, init_packet_vars[PacketField.REQUIRED_SOFTDEVICES_ARRAY] might have already been set to sd_id. This would overwrite that.
If the same init packet field is being used for both --sd-req and --sd-id, then why do we need --sd-id? Couldn't we just use --sd-req?
There was a problem hiding this comment.
Sorry, I thought init_packet_vars was the final init packet, but I see now that init_packet_vars is just a temporary variable. The init_packet_vars is mutated with different softdevice requirements between each call to __add_firmware_info(). Then it makes sense.
nordicsemi/version.py
Outdated
| @@ -37,4 +37,4 @@ | |||
|
|
|||
| """ Version definition for nrfutil. """ | |||
|
|
|||
| NRFUTIL_VERSION = "2.2.0" | |||
| NRFUTIL_VERSION = "2.3.0" | |||
There was a problem hiding this comment.
2.3.0 has now been released, so this should be bumped to 2.4.0. There is also a merge conflict that needs to be resolved.
The new parameter allows to specify required SD_REQ for SD(+BL) update and App update if they are in the same ZIP file and are to be sent in 2 connections. The second update with and App will require the ID ot the just-flashed SD, not the one that was before the first update.