This repository was archived by the owner on Jan 17, 2023. It is now read-only.
Implement ultra-verbosity for showing all bytes sent/received over serial #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bihanssen
reviewed
Jan 12, 2018
| @@ -166,7 +166,7 @@ def convert(self, value, param, ctx): | |||
|
|
|||
| @click.group() | |||
| @click.option('-v', '--verbose', | |||
| help='Show verbose information.', | |||
| help='Increase verbosity of output. Can be specified more than once (up to -v -v -v -v).', | |||
There was a problem hiding this comment.
Suggest writing as -vvvv
| @@ -115,6 +115,7 @@ def __init__(self, serial_port): | |||
|
|
|||
| def send_message(self, data): | |||
| packet = Slip.encode(data) | |||
| logger.log(5, 'SLIP: --> ' + str(data)) | |||
There was a problem hiding this comment.
Magic number. Suggest using a named variable. Lines 118 and 136.
mrodem
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been debugging some bits of the DFU protocol, and I found it very useful to increase the available verbosity levels, adding a custom level for displaying all bytes.
A bit hackish (should this define a new logging level at a global level?), but the changes are small and useful.