Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move shouldMergeCompilationJobs call to the build system #6416

Merged
merged 6 commits into from
Mar 4, 2025

Conversation

galargh
Copy link
Member

@galargh galargh commented Feb 26, 2025

  • Because this PR includes a bug fix, relevant tests have been included.
  • Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
  • I didn't do anything of this.

We should call shouldMergeCompilationJobs only if BuildOptions.mergeCompilationJobs parameter wasn't passed to the build system explicitly.

@galargh galargh requested a review from kanej February 26, 2025 14:14
Copy link

changeset-bot bot commented Feb 26, 2025

🦋 Changeset detected

Latest commit: 4909f3f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
hardhat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 3, 2025 10:14am

@github-actions github-actions bot added the status:ready This issue is ready to be worked on label Feb 26, 2025
if (options?.mergeCompilationJobs === true) {
if (
options?.mergeCompilationJobs ??
shouldMergeCompilationJobs(buildProfileName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To confirm my understanding. Instead of saying that invocations of the build system's build should set a bool on merging compilation jobs at each invocation site; we switch to there being a default behavior that matches the current two invocations?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, exactly! I want the shouldMergeCompilationJobs(buildProfileName) to become the default. The users of build() would still be able to set the mergeCompilationJobs bool option if they so choose.

Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense given that we pass in the buildProfile.

@galargh galargh added this pull request to the merge queue Mar 3, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Mar 3, 2025
@kanej kanej added this pull request to the merge queue Mar 4, 2025
Merged via the queue into v-next with commit 2a6fcce Mar 4, 2025
76 checks passed
@kanej kanej deleted the should-merge-compilation-jobs branch March 4, 2025 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:ready This issue is ready to be worked on
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants