-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move shouldMergeCompilationJobs call to the build system #6416
Conversation
🦋 Changeset detectedLatest commit: 4909f3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
if (options?.mergeCompilationJobs === true) { | ||
if ( | ||
options?.mergeCompilationJobs ?? | ||
shouldMergeCompilationJobs(buildProfileName) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To confirm my understanding. Instead of saying that invocations of the build system's build
should set a bool on merging compilation jobs at each invocation site; we switch to there being a default behavior that matches the current two invocations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, exactly! I want the shouldMergeCompilationJobs(buildProfileName)
to become the default. The users of build()
would still be able to set the mergeCompilationJobs
bool option if they so choose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this makes sense given that we pass in the buildProfile
.
We should call
shouldMergeCompilationJobs
only ifBuildOptions.mergeCompilationJobs
parameter wasn't passed to the build system explicitly.