You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this PR includes a bug fix, relevant tests have been included.
Because this PR includes a new feature, the change was previously discussed on an Issue or with someone from the team.
I didn't do anything of this.
It's not much but it can cause confusion in the documentation. Above the documentation makes us export the "DemoModule" and here we use "useModule" with the proxy module which is not supposed to be exported, I therefore deduce that we must use the import which was introduced above.
Thank you for taking the time to read me and have a good day.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Yep, this looks right, good catch! There are a couple more references to this mistake that should be fixed on lines 315, 323, 356, 364, and 394. If you would correct those as well then we can get this merged @EnThib
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not much but it can cause confusion in the documentation. Above the documentation makes us export the "DemoModule" and here we use "useModule" with the proxy module which is not supposed to be exported, I therefore deduce that we must use the import which was introduced above.
Thank you for taking the time to read me and have a good day.