-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a guide for using the create2 strategy #4758
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
We should update this in light of our create2 config changes. |
5dfb127
to
aa6a8f3
Compare
I think there are too many ":::tip" here, it doesn't look good when rendered. Some proposed changes:
WDYT @zoeyTM ? |
@alcuadrado I would really like to keep the one note about security considerations, so I ended up only adding that one CreateX tip at the very top of the page, and deleting the others. Let me know what you think; I'm happy to remove it and/or the one regarding the quick start guide if you still want to. |
Update the text to indicate that the salt is required. Also set a valid but obviously example salt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should wait for the release, but is signed off.
resolves NomicFoundation/hardhat-ignition#670
depends on NomicFoundation/hardhat-ignition#626