Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a guide for using the create2 strategy #4758

Merged
merged 9 commits into from
Mar 13, 2024
Merged

Conversation

zoeyTM
Copy link
Contributor

@zoeyTM zoeyTM commented Jan 12, 2024

@zoeyTM zoeyTM requested a review from kanej January 12, 2024 06:36
Copy link

changeset-bot bot commented Jan 12, 2024

⚠️ No Changeset found

Latest commit: f1b4f2c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Jan 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hardhat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 0:06am

@kanej
Copy link
Member

kanej commented Feb 16, 2024

We should update this in light of our create2 config changes.

@kanej kanej force-pushed the ignition/create2-guide branch from 5dfb127 to aa6a8f3 Compare March 5, 2024 11:21
@kanej kanej added status:ready This issue is ready to be worked on no changeset needed This PR doesn't require a changeset and removed status:triaging labels Mar 5, 2024
@alcuadrado
Copy link
Member

I think there are too many ":::tip" here, it doesn't look good when rendered.

Some proposed changes:

  • Remove all the tips
  • Add a section at the top, explaining what CreateX, explaining its security considerations (just like the current tip), and linking to its docs. Basically replacing the CreateX-related tips with a section.

WDYT @zoeyTM ?

@zoeyTM
Copy link
Contributor Author

zoeyTM commented Mar 7, 2024

@alcuadrado I would really like to keep the one note about security considerations, so I ended up only adding that one CreateX tip at the very top of the page, and deleting the others. Let me know what you think; I'm happy to remove it and/or the one regarding the quick start guide if you still want to.

Update the text to indicate that the salt is required.

Also set a valid but obviously example salt.
Copy link
Member

@kanej kanej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should wait for the release, but is signed off.

@kanej kanej merged commit 8c3b196 into main Mar 13, 2024
30 checks passed
@kanej kanej deleted the ignition/create2-guide branch March 13, 2024 23:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
no changeset needed This PR doesn't require a changeset status:ready This issue is ready to be worked on
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create2 Guide
3 participants