Made all errors internal #678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanej
force-pushed
the
chore/move-errors-to-internal
branch
from
917b8fa to
483eb9b
Compare
kanej
requested changes
Jan 16, 2024
There was a problem hiding this comment.
I removed the API tags (i.e. @Alpha & @beta) for all the functions/constants in internal. This threw up a few failures:
For those on the list that are really types lets add a ./src/types/error.ts with those. For the others, they should be moved back out of internal into the top level, with references to the internal elements.
The goal is to minimize what is publicly exposed and to be explicit between what is public/internal.
kanej
approved these changes
Jan 18, 2024
kanej
added a commit
that referenced
this pull request
Jan 25, 2024
* moved errors to internal * chore: remove alpha/beta tags from internal * fix api extractor tags * refactor: remove unneeded intermediary function --------- Co-authored-by: John Kane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #581