Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nfs: add idmapd.settings option #98980

Merged
merged 1 commit into from
Nov 18, 2020
Merged

nixos/nfs: add idmapd.settings option #98980

merged 1 commit into from
Nov 18, 2020

Conversation

justinlovinger
Copy link
Contributor

Motivation for this change

Fixes #97616

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Sep 28, 2020
@aanderse aanderse requested a review from infinisil October 21, 2020 00:01
aanderse
aanderse approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@infinisil do you mind reviewing this too?

infinisil
infinisil approved these changes Oct 21, 2020
View reviewed changes
Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Maybe the commits could be squashed together though

@justinlovinger
Copy link
Contributor Author

@infinisil I kept the separate commits to give @aanderse proper credit, but I can squash them if you'd prefer and @aanderse is fine with it.

@aanderse
Copy link
Member

Squash away 👍

@justinlovinger
Copy link
Contributor Author

Squash done 👍 @infinisil

@infinisil
Copy link
Member

You can add a Co-authored-by: ... field in the commit message to give credit to more people, see https://github.blog/2018-01-29-commit-together-with-co-authors/ :)

@justinlovinger
Copy link
Contributor Author

@infinisil Done. I wasn't aware of that option before 🙂

@aanderse
Copy link
Member

I completely lost track of this... we're good to merge, right?

@infinisil infinisil merged commit 3307adf into NixOS:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add options to configure idmapd.conf
3 participants
@justinlovinger @aanderse @infinisil