feeds: init at 0.16.1 #92339

pbogdan · 2020-07-05T14:41:41Z

Motivation for this change

Add (g)feeds - an RSS/Atom feed reader for GNOME. Closes #91370.

Things done

I'm not familiar with Python / meson packaging so any feedback would be appreciated. The expression is largely based on the lollypop package.

Also one thing to note - I'm not sure what the package should be called gfeeds or just feeds. The executable is named gfeeds so is the upstream repo while the included desktop file names it as feeds and the package seems to be in a transition period.

I also picked a commit that was most recent version of master at the time I wrote the expression. The most recent tagged release had trouble parsing some of my feeds which was fixed on master so I used that instead try to hunt down the relevant patches to apply on top of a tagged release.

/cc @Metadark who expressed interest in the package
/cc @jtojnar @worldofpeace as resident GNOME experts

jtojnar · 2020-07-05T15:05:21Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+, python3
+}:
+let
+  listparser = python3.pkgs.buildPythonPackage rec {


Why not add this to python-packages?

Nothing else depends on it, and the package also hasn't been updated in a good while (last commit on the upstream repo is from September 2017). I was under (perhaps wrong) impression Python maintainers are reluctant to accept a new package like this and making it a private / vendored package was preferred.

That makes sense. I think that's a pretty good reason for keeping it private.

jtojnar · 2020-07-05T15:05:45Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+      six
+    ];
+
+    doCheck = false;


Could you add a comment why this is disabled?

Default checkPhase doesn't seem to do anything (Ran 0 tests..). I'm not familiar with Python ecosystem at all, perhaps I'm just missing a checkInputs dependency but I simply don't know how to properly invoke the check phase so that tests are ran (the tests folder and its contents are present in the PyPI archive).

Hmm, you might need to explicitly specify checkPhase.

I think this is in context of listparser. I just added a commit that runs the tests based on what I found in tox.ini. The test suite however fails :-(. Maybe I'm missing something obvious but based on the output I really don't understand why.. Any ideas what's happening?

NVM, I was looking at the development branch of the package instead of the tagged release, test should now run and pass with the commit I just pushed.

pkgs/applications/networking/feedreaders/feeds/default.nix

jtojnar · 2020-07-05T15:11:12Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+in
+python3.pkgs.buildPythonApplication rec {
+  pname = "feeds-unstable";
+  version = "22-06-2020";


https://xkcd.com/1179/

Except for the version format, this looks good to me. Thanks @pbogdan!

pkgs/applications/networking/feedreaders/feeds/default.nix

kira-bruneau

Thank you for packaging this!

kira-bruneau · 2020-07-05T14:53:39Z

pkgs/top-level/all-packages.nix

@@ -3442,6 +3442,8 @@ in

  feedreader = callPackage ../applications/networking/feedreaders/feedreader {};

+  feeds = callPackage ../applications/networking/feedreaders/feeds {};


I've seen other packages use python3Packages.callPackage so python packages are passed as arguments to the expression. I prefer it over accessing them through python3.pkgs / python3Packages, but I'm not sure if it's the generally accepted approach.

The opinions are somewhat mixed, slightly leaning to avoiding it. The main disadvantage is that it just shifts the qualified accessor to normal packages, that is, we would need to use pkgs.meson…

I've used it before without needing to qualify normal packages:

nixpkgs/pkgs/development/tools/cmake-language-server/default.nix

Line 3 in 93ebfda

, cmake, pytest, pytest-datadir

nixpkgs/pkgs/development/python-modules/debugpy/default.nix

Line 2 in a408cd9

, substituteAll, gdb

There are sometimes conflicts between normal packages and python packages. You would want to use pkgconfig or meson from all-package.nix but you would get the python package with the same name. (pkg-config now has a different name but the legacy alias still conflicts.) And when https://pypi.org/project/cmake/ is packaged, your package breaks.

Ah, good point 😄. I will fix that next update.

kira-bruneau · 2020-07-05T14:55:59Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+  listparser = python3.pkgs.buildPythonPackage rec {
+    pname = "listparser";
+    version = "0.18";
+
+    src = python3.pkgs.fetchPypi {
+      inherit pname version;
+      sha256 = "0hdqs1mmayw1r8yla43hgb4d9y3zqs5483vgf8j9ygczkd2wrq2b";
+    };
+
+    propagatedBuildInputs = with python3.pkgs; [
+      requests
+      six
+    ];
+
+    doCheck = false;
+
+    meta = with lib; {
+      description = "A parser for subscription lists";
+      homepage = "https://github.com/kurtmckee/listparser";
+      license = licenses.lgpl3;
+      maintainers = [
+        maintainers.pbogdan
+      ];
+      platforms = platforms.linux;
+    };
+  };


It might be better to move this into pkgs/development/python-modules/listparser to separate this from Gnome Feeds, and so it can be used by other packages in the future.

I would also recommend directly pulling the sources from https://github.com/kurtmckee/listparser to run the tests.

Correction: It looks like the tests are included in the pypi package, so you might not need to pull the sources directly from the git repo.

@worldofpeace You asked me to do this before for #64705. What do you suggest here?

jtojnar · 2020-07-05T15:34:32Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+  };
+in
+python3.pkgs.buildPythonApplication rec {
+  pname = "feeds-unstable";


That is the convention when obtaining a git commit instead of tag, see https://nixos.org/nixpkgs/manual/#sec-package-naming. It is also controversial: #88023 (comment)

I just noticed that @pbogdan mentioned that the latest release version doesn't work, so I deleted my comments related to it.

jtojnar · 2020-07-05T15:34:32Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+  };
+in
+python3.pkgs.buildPythonApplication rec {
+  pname = "feeds-unstable";


That is the convention when obtaining a git commit instead of tag, see https://nixos.org/nixpkgs/manual/#sec-package-naming. It is also controversial: #88023 (comment)

doronbehar · 2020-12-16T20:08:56Z

error: --- Error --- nix-daemon
hash mismatch in fixed-output derivation '/nix/store/iw6fak8svqdsabkrd3dwma2x94x6mq47-source.drv':
  specified: sha256-GVXRic7cOtFiu7CXsPEykFd2JMLlrRDwJ91KwLMqBH8=
     got:    sha256-MxFV5kytpJR8irHfo+WuAw0zDesTk4FxG5XR060BGII=
error: --- Error --- nix-daemon
1 dependencies of derivation '/nix/store/5200wklds26rrpj0vqcgyfp1gk1ys8mk-feeds-0.16.1.drv' failed to build
error: --- Error ------------------------------------------------------------------------------------- nix
1 dependencies of derivation '/nix/store/aa0ksr66h69my33aa31681lk9acy8580-env.drv' failed to build

Link to currently reviewing PR:
https://github.com/NixOS/nixpkgs/pull/92339

1 package failed to build:
feeds

error: --- Error ------------------------------------------------------------------------------------- nix

jtojnar · 2020-12-16T20:09:20Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+
+    src = python3.pkgs.fetchPypi {
+      inherit pname version;
+      sha256 = "0hdqs1mmayw1r8yla43hgb4d9y3zqs5483vgf8j9ygczkd2wrq2b";


One issue might be that r-ryantm might not update files with multiple hashes in them.

doronbehar · 2020-12-17T09:22:29Z

pkgs/applications/networking/feedreaders/feeds/default.nix

+, python3
+}:
+let
+  listparser = import ./listparser.nix {


I think now it's impossible to override it in case it fails to build.. You should also be able to use callPackage instead which is a bit more versatile - you won't need inherit lib python3;. If we would like to not add it to python-packages.nix, we can put in the arguments list:

, listparser ? callPackage ./listparser.nix { }

And then inside the feeds expression, use passthru = { inherit listparser; }; - this will expose it and allow it to be overridden in case it fails to build.

Can you explain why it should go into passthru? I don't quite see how that's going to help with overriding.

With the passthru, one should be able to:

self: super: { feeds-with-different-listparser = super.feeds.override { # No need to use the `passthru` attribute, but it helps the usage be clear listparser = super.feeds.passthru.listparser.overrideAttrs(oldAttrs: { /* src = ...; */ }); }; }

doronbehar · 2020-12-18T08:25:53Z

Result of nixpkgs-review pr 92339 run on x86_64-linux 1

1 package built:

feeds

dotlambda · 2021-04-10T10:06:55Z

Was there any discussion about the name? Arch and Guix call this package gfeeds (https://repology.org/project/gfeeds), everyone else calls it gnome-feeds (https://repology.org/project/gnome-feeds).
I think we should rename it to gfeeds.

doronbehar · 2021-04-10T17:40:43Z

Was there any discussion about the name? Arch and Guix call this package gfeeds (repology.org/project/gfeeds), everyone else calls it gnome-feeds (repology.org/project/gnome-feeds).
I think we should rename it to gfeeds.

Good point, I was thinking about this myself as well. Let's do it before it reaches stable. Renaming it's pname to gfeeds and attribute to gnome-feeds in: #119067

ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Jul 5, 2020

jtojnar reviewed Jul 5, 2020

View reviewed changes

kira-bruneau requested changes Jul 5, 2020

View reviewed changes

jtojnar reviewed Jul 5, 2020

View reviewed changes

pbogdan force-pushed the add-feeds branch 4 times, most recently from b3d31c7 to 954e12d Compare July 5, 2020 17:36

pbogdan changed the title ~~feeds-unstable: init at 22-06-2020~~ feeds-unstable: init at 2020-06-22 Jul 5, 2020

kira-bruneau approved these changes Jul 5, 2020

View reviewed changes

pbogdan force-pushed the add-feeds branch from 954e12d to accf473 Compare September 30, 2020 20:27

pbogdan force-pushed the add-feeds branch from accf473 to cd6e765 Compare December 7, 2020 18:53

pbogdan changed the title ~~feeds-unstable: init at 2020-06-22~~ feeds: init at 0.16.1 Dec 7, 2020

doronbehar approved these changes Dec 16, 2020

View reviewed changes

jtojnar reviewed Dec 16, 2020

View reviewed changes

pbogdan force-pushed the add-feeds branch 2 times, most recently from 504e3c0 to 1b52c9d Compare December 16, 2020 20:57

doronbehar requested changes Dec 17, 2020

View reviewed changes

feeds: init at 0.16.1

35c588a

pbogdan force-pushed the add-feeds branch from 1b52c9d to 35c588a Compare December 17, 2020 19:50

doronbehar merged commit 5277b1d into NixOS:master Dec 18, 2020

doronbehar mentioned this pull request Apr 10, 2021

feeds: Rename to gnome-feeds #119067

Merged

10 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feeds: init at 0.16.1 #92339

feeds: init at 0.16.1 #92339

pbogdan commented Jul 5, 2020

jtojnar Jul 5, 2020

pbogdan Jul 5, 2020

kira-bruneau Jul 5, 2020

jtojnar Jul 5, 2020

pbogdan Jul 5, 2020

kira-bruneau Jul 5, 2020 •

edited

Loading

pbogdan Jul 5, 2020

pbogdan Jul 5, 2020

jtojnar Jul 5, 2020

kira-bruneau Jul 5, 2020 •

edited

Loading

kira-bruneau left a comment

kira-bruneau Jul 5, 2020

jtojnar Jul 5, 2020

kira-bruneau Jul 5, 2020

jtojnar Jul 5, 2020 •

edited

Loading

kira-bruneau Jul 5, 2020 •

edited

Loading

kira-bruneau Jul 5, 2020

kira-bruneau Jul 5, 2020 •

edited

Loading

jtojnar Jul 5, 2020

kira-bruneau Jul 5, 2020

jtojnar Jul 5, 2020

doronbehar commented Dec 16, 2020

jtojnar Dec 16, 2020

doronbehar Dec 17, 2020

pbogdan Dec 17, 2020

doronbehar Dec 17, 2020

doronbehar commented Dec 18, 2020

dotlambda commented Apr 10, 2021 •

edited

Loading

doronbehar commented Apr 10, 2021

		@@ -3442,6 +3442,8 @@ in

		feedreader = callPackage ../applications/networking/feedreaders/feedreader {};

		feeds = callPackage ../applications/networking/feedreaders/feeds {};

feeds: init at 0.16.1 #92339

feeds: init at 0.16.1 #92339

Conversation

pbogdan commented Jul 5, 2020

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kira-bruneau Jul 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kira-bruneau Jul 5, 2020 • edited Loading

Choose a reason for hiding this comment

kira-bruneau left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jtojnar Jul 5, 2020 • edited Loading

Choose a reason for hiding this comment

kira-bruneau Jul 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kira-bruneau Jul 5, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doronbehar commented Dec 16, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

doronbehar commented Dec 18, 2020

dotlambda commented Apr 10, 2021 • edited Loading

doronbehar commented Apr 10, 2021

kira-bruneau Jul 5, 2020 •

edited

Loading

kira-bruneau Jul 5, 2020 •

edited

Loading

jtojnar Jul 5, 2020 •

edited

Loading

kira-bruneau Jul 5, 2020 •

edited

Loading

kira-bruneau Jul 5, 2020 •

edited

Loading

dotlambda commented Apr 10, 2021 •

edited

Loading