vscode-extensions.vadimcn.vscode-lldb: init at 1.5.3

[oxalica]

Motivation for this change

Package vadimcn.vscode-lldb, a new vscode extension for debugging and pretty print support (especially for rust) with native lldb.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
  • 593 MiB (~94 MiB itself. Others are lldb, python3, etc.)
• Ensured that relevant documentation is up to date
• Fits CONTRIBUTING.md.

[monomadic]

I'd love for this to be merged - for others who can't wait, I suggest downloading the full vsix manually from the the owners github https://github.com/vadimcn/vscode-lldb/releases

and installing it from command line. you'll have to manually patch the executables inside the extension with patchelf and link to the python 3.5 lib manually in your vscode settings.

But I'm guessing this PR would negate the need for all of that!

[oxalica]

ping @jonringer

[oxalica]

Refactored to use standalone generated node-packages.nix without touching global nodePackages.

[oxalica]

According to #97444 (comment), change to use global node-packages.nix again.

r? @jonringer

[midchildan]

This looks like an unused variable, is it possible to remove it?

[midchildan]

Could you add a comment explaining why this is necessary? (e.g., vscode-lldb loads libpython at runtime)

[midchildan]

This would also deserve a comment.

[midchildan]

Include the version in name. Also include the version attribute in the derivation to make it easy to extract the version when generating package.json.

Suggested change

	inherit name;
	inherit version;
	name = "${name}-${version}";

[midchildan]

It would help to include a script (maybe generate.sh?) that would generate this automatically. Here's an example:

#!/usr/bin/env bash

# Script to generate package.json needed to create the build environment.

set -eu -o pipefail
cd "$(dirname "${BASH_SOURCE[0]}")"

SRC="$(nix-build -A vscode-extensions.vadimcn.vscode-lldb.src.src --no-out-link ../../../..)"
VERSION="$(nix-instantiate --eval -A vscode-extensions.vadimcn.vscode-lldb.version ../../../.. | tr -d '"')"
JQ_BIN="$(nix-build -A jq --no-out-link ../../../..)/bin/jq"


main() {
    jq "{\"name\": \"vscode-lldb\", \"version\": \"$VERSION\", \"dependencies\": (.devDependencies + .dependencies)}" \
        "$SRC/package.json" \
        > build-deps/package.json
}

jq() {
    command "$JQ_BIN" "$@"
}

main

[jonringer]

This PR has been going on for months, I think we could have another PR to do refinements.

[jonringer]

was able to build it.