Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "treewide: replace base64 encoded hashes" #89520

Closed
wants to merge 1 commit into from
Closed

Revert "treewide: replace base64 encoded hashes" #89520

wants to merge 1 commit into from

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jun 5, 2020

This reverts commit 7b3a296.

Motivation for this change

The original change breaks node2nix updates #89423 (comment)
To properly get rid of base64 would require additional work to be done on node2nix side.

Things done
  • Tested to eval with Nix 2.0:
nix-shell -I nixpkgs=https://github.com/NixOS/nixpkgs/archive/48d9754d2b110ea4b5e7248b74eec52befcd136c.tar.gz -p nix --pure --run "nix-build --version && nix-build . -A lingot.src"

@veprbl veprbl requested review from FRidh and jonringer as code owners June 5, 2020 03:00
@veprbl veprbl requested review from LnL7 and edolstra June 5, 2020 03:00
@veprbl veprbl mentioned this pull request Jun 5, 2020
Closed
10 tasks
@ofborg ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jun 5, 2020
@veprbl veprbl mentioned this pull request Jun 7, 2020
Closed
11 tasks
@veprbl
Copy link
Member Author

veprbl commented Jun 8, 2020

Effectively reverted in #89649

@veprbl veprbl closed this Jun 8, 2020
@veprbl veprbl deleted the pr/revert_89423 branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@LnL7 LnL7 Awaiting requested review from LnL7

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: python 8.has: documentation This PR adds or changes documentation 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@veprbl