Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.qiskit: 0.17.0 -> 0.18.2 #84943

Merged
merged 9 commits into from
Apr 24, 2020
Merged

python3Packages.qiskit: 0.17.0 -> 0.18.2 #84943

merged 9 commits into from
Apr 24, 2020

Conversation

drewrisinger
Copy link
Contributor

Motivation for this change

Update qiskit to latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from pandaman64 April 10, 2020 21:50
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 labels Apr 10, 2020
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

python38Packages.qiskit is not available due to upstream breakages in master (I think pythonPackages.aiohttp -> ... -> pythonPackages.qiskit-ibmq-provider). Building ignis builds [terra, air, ignis], so it's a good enough proxy.

@drewrisinger drewrisinger marked this pull request as ready for review April 10, 2020 22:24
@drewrisinger
Copy link
Contributor Author

nixpkgs-review pr 84943:
#84943
26 package marked as broken and skipped:
gdata-sharp iterm2 linuxPackages_4_4.evdi linuxPackages_hardkernel_4_14.bcc linuxPackages_hardkernel_4_14.bpftrace linuxPackages_hardkernel_4_14.can-isotp linuxPackages_hardkernel_4_14.chipsec linuxPackages_hardkernel_4_14.digimend linuxPackages_hardkernel_4_14.evdi linuxPackages_hardkernel_4_14.mba6x_bl linuxPackages_hardkernel_4_14.nvidia_x11 linuxPackages_hardkernel_4_14.nvidia_x11_legacy390 linuxPackages_hardkernel_4_14.nvidiabl linuxPackages_hardkernel_4_14.prl-tools newlibCross octave-jit php73Extensions.zmq php74Extensions.couchbase python27Packages.caffe python27Packages.habanero python27Packages.handout python27Packages.hass-nabucasa python37Packages.pyblock python38Packages.nixpart python38Packages.poezio python38Packages.qiskit-ibmq-provider

16 package built:
python27Packages.python-constraint python37Packages.fastjsonschema python37Packages.python-constraint python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aer python37Packages.qiskit-aqua python37Packages.qiskit-ibmq-provider python37Packages.qiskit-ignis python37Packages.qiskit-terra python38Packages.fastjsonschema python38Packages.python-constraint python38Packages.qiskit-aer python38Packages.qiskit-aqua python38Packages.qiskit-ignis python38Packages.qiskit-terra

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

@drewrisinger
Copy link
Contributor Author

Last push was just a cleanup/meta change, all packages have same hash after.

@drewrisinger
Copy link
Contributor Author

Update: added retworkx from #84945 (figured out how to get it stable), and then force-pushed.
@GrahamcOfBorg build python37Packages.retworkx python38Packages.retworkx
@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

@drewrisinger drewrisinger changed the title python3Packages.qiskit: 0.17.0 -> 0.18.0 python3Packages.qiskit: 0.17.0 -> 0.18.1 Apr 21, 2020
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

@FRidh
Copy link
Member

FRidh commented Apr 21, 2020

Some build is still failing.

@drewrisinger
Copy link
Contributor Author

@FRidh scipy build is failing (#85637) due to #83888 (#85636 will resolve).
When branch is checked out locally (rebased on commit prior to #83888 merge), it builds fine.

Relevant section from borg log:

numpy.distutils.system_info.NotFoundError: No lapack/blas resources found.
builder for '/nix/store/k55al0ykln7iszalhv6qm8fsjjasvgif-python3.8-scipy-1.4.1.drv' failed with exit code 1

@drewrisinger drewrisinger mentioned this pull request Apr 21, 2020
Merged
10 tasks
@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

@drewrisinger
Copy link
Contributor Author

@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

Result of running nixpkgs-review pr 84943:
#84943
18 package built:
python27Packages.python-constraint python37Packages.fastjsonschema python37Packages.python-constraint python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aer python37Packages.qiskit-aqua python37Packages.qiskit-ibmq-provider python37Packages.qiskit-ignis python37Packages.qiskit-terra python37Packages.retworkx python38Packages.fastjsonschema python38Packages.python-constraint python38Packages.qiskit-aer python38Packages.qiskit-aqua python38Packages.qiskit-ignis python38Packages.qiskit-terra python38Packages.retworkx

@drewrisinger drewrisinger force-pushed the dr-pr-qiskit-bump branch 2 times, most recently from c221073 to eddfe40 Compare April 22, 2020 15:12
@drewrisinger
Copy link
Contributor Author

fixed a minor reference issue (from comments only) & updated to latest master version.
@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

@drewrisinger
python3Packages.retworkx: init at 0.3.3
e218af2 
Replacement for networkx in qiskit-terra.
@drewrisinger
python3Packages.qiskit-terra: 0.12.0 -> 0.13.0
c6ea35d 
Also add in optional visualization inputs as default to ensure that
they are in the environment when used at runtime.
Some hacks to avoid packaging retworkx (uses a semi-complicated Rust ->
Python packaging system, will try to get that packaged in future).
For now, just disabling retworkx, will need to package it in future.
@drewrisinger
python3Packages.qiskit-aer: 0.4.1 -> 0.5.0
aec8e04
@drewrisinger
python3Packages.qiskit-ignis: 0.2.0 -> 0.3.0
88d4934
@drewrisinger
python3Packages.qiskit-aqua: 0.6.5 -> 0.6.6
19abfc4
@drewrisinger
python3Packages.qiskit-ibmq-provider: 0.6.0 -> 0.6.1
c17bbad
@drewrisinger
python3Packages.qiskit: 0.17.0 -> 0.18.2
4238afc
@drewrisinger drewrisinger changed the title python3Packages.qiskit: 0.17.0 -> 0.18.1 python3Packages.qiskit: 0.17.0 -> 0.18.2 Apr 24, 2020
@drewrisinger
Copy link
Contributor Author

Added update of qiskit-ibmq-provider
@GrahamcOfBorg build python37Packages.qiskit python38Packages.qiskit-ignis

bhipple
bhipple approved these changes Apr 24, 2020
View reviewed changes
pkgs/development/python-modules/retworkx/default.nix
version = rx-version;
format = "wheel";

disabled = pythonOlder "3.5" || pythonAtLeast "3.9"; # compiled versions only included for 3.5 <= py <= 3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally we would just cleanly compile this thing entirely from source:
https://github.com/Qiskit/retworkx#building-from-source

but it looks like that might be a project in and of itself with the Rust bindings.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I tried doing that in #84945 before I gave up. It gets messy and requires a lot of other modules, which themselves require the Rust nightly build which then requires an overlay of nixpkgs...

@bhipple
Copy link
Contributor

bhipple commented Apr 24, 2020

Result of nixpkgs-review pr 84943 1

18 packages built:
- python27Packages.python-constraint
- python37Packages.fastjsonschema
- python37Packages.python-constraint
- python37Packages.qasm2image
- python37Packages.qiskit
- python37Packages.qiskit-aer
- python37Packages.qiskit-aqua
- python37Packages.qiskit-ibmq-provider
- python37Packages.qiskit-ignis
- python37Packages.qiskit-terra
- python37Packages.retworkx
- python38Packages.fastjsonschema
- python38Packages.python-constraint
- python38Packages.qiskit-aer
- python38Packages.qiskit-aqua
- python38Packages.qiskit-ignis
- python38Packages.qiskit-terra
- python38Packages.retworkx

@bhipple bhipple merged commit acdd239 into NixOS:master Apr 24, 2020
@drewrisinger drewrisinger deleted the dr-pr-qiskit-bump branch April 24, 2020 13:45
@drewrisinger
Copy link
Contributor Author

Thanks for the feedback @bhipple!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@pandaman64 pandaman64 Awaiting requested review from pandaman64

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drewrisinger @FRidh @bhipple