Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox: 74.0 -> 74.0.1 #84211

Merged
merged 5 commits into from
Apr 4, 2020
Merged

firefox: 74.0 -> 74.0.1 #84211

merged 5 commits into from
Apr 4, 2020

Conversation

andir
Copy link
Member

@andir andir commented Apr 3, 2020

Motivation for this change

This is a security update for firefox 74: https://www.mozilla.org/en-US/security/advisories/mfsa2020-11/

This PR also updates all the other versions of firefox we currently have in the tree. It is likely they suffered from the same or similar issues and also have received updates.

Working on the 19.09 and 20.03 versions of these.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from edolstra April 3, 2020 21:03
@ofborg ofborg bot added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 labels Apr 3, 2020
@flokli flokli mentioned this pull request Apr 4, 2020
Merged
@samueldr samueldr added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Apr 4, 2020
KamilaBorowska
KamilaBorowska approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@KamilaBorowska KamilaBorowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and executed firefox package, it correctly shows 74.0.1 as a version.

@andir andir merged commit da542ec into NixOS:master Apr 4, 2020
@andir andir mentioned this pull request Apr 4, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KamilaBorowska KamilaBorowska KamilaBorowska approved these changes

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andir @KamilaBorowska @samueldr