Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] chromium: 80.0.3987.149 -> 80.0.3987.163 (backport) #84107

Merged
merged 4 commits into from
Apr 3, 2020
Merged

[19.09] chromium: 80.0.3987.149 -> 80.0.3987.163 (backport) #84107

merged 4 commits into from
Apr 3, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Apr 2, 2020 •
edited
Loading

Motivation for this change

Backport of #83956 (edit: fixed the reference).

Testing status
platform attribute status tester
x86_64 chromium ✔️ @Frostman
x86_64 nixosTests.chromium ✔️ @Frostman
x86_64 google-chrome ✔️ @primeos
aarch64 chromium - -
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added 3 commits April 2, 2020 15:21
@peti @primeos
chromium: fix webrtc interaction with pulseaudio
190fbfd 
The webrtc code suffered from a race condition when used
with Pulseaudio. This lead to audio input breaking every
couple of minutes during a webrtc session.

(cherry picked from commit 81b18c3)
@peti @primeos
chromium: I accidentally added the webrtc patch into the wrong section
5ae092f 
(cherry picked from commit b3c2908)
@primeos
chromium: 80.0.3987.149 -> 80.0.3987.162
96614c2 
https://chromereleases.googleblog.com/2020/03/stable-channel-update-for-desktop_31.html

This update includes 8 security fixes.

CVEs:
CVE-2020-6450 CVE-2020-6451 CVE-2020-6452

(cherry picked from commit 6b7528c)
@primeos primeos added 2.status: work-in-progress This PR isn't done 1.severity: security Issues which raise a security issue, or PRs that fix one labels Apr 2, 2020
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 2, 2020
@Frostman
Copy link
Member

Frostman commented Apr 2, 2020

chromium tests passed ok (x86_64)

@primeos
chromium: 80.0.3987.162 -> 80.0.3987.163
1ca8a06 
https://chromereleases.googleblog.com/2020/04/stable-channel-update-for-desktop.html

Note: This update contains only two fixes [0]. The fix that reverts a
feature which caused a crash spike on 80.0.3987.162 [1] seems important
for us (though the commit doesn't provide any data on the crash spike).

[0]: https://chromium.googlesource.com/chromium/src/+log/80.0.3987.162..80.0.3987.163?pretty=fuller
[1]: https://chromium.googlesource.com/chromium/src/+/fc11c43603c05a9ef77430a6b4081a01969d2bf4

(cherry picked from commit cbd13f3)
@primeos primeos changed the title [19.09] chromium: 80.0.3987.149 -> 80.0.3987.162 (backport) [19.09] chromium: 80.0.3987.149 -> 80.0.3987.163 (backport) Apr 3, 2020
@Frostman
Copy link
Member

Frostman commented Apr 3, 2020

chromium tests are still passing (with -> .163 commit)

@primeos primeos merged commit 6ce362a into NixOS:release-19.09 Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 2.status: work-in-progress This PR isn't done 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@primeos @Frostman @peti