Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[19.09] gitlab 12.8.5 -> 12.8.6 #82376

Merged
merged 3 commits into from
Mar 12, 2020
Merged

[19.09] gitlab 12.8.5 -> 12.8.6 #82376

merged 3 commits into from
Mar 12, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Mar 12, 2020

Motivation for this change

backport of #82374

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

flokli added 2 commits March 12, 2020 03:06
@flokli
gitlab: update script: unset GOROOT
f030d5e 
or vgo2nix might not be able to resolve some dependencies.

(cherry picked from commit d2061f0)
@flokli
gitlab: 12.8.5 -> 12.8.6
a3c8911 
https://about.gitlab.com/releases/2020/03/11/critical-security-release-gitlab-12-dot-8-dot-6-released/
(cherry picked from commit ab3b836)
@flokli flokli added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Mar 12, 2020
@flokli flokli requested review from talyz, fpletz, globin, a user and Ma27 March 12, 2020 02:10
@flokli
Copy link
Contributor Author

flokli commented Mar 12, 2020

@GrahamcOfBorg test gitlab

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 12, 2020
@flokli
gitaly: 12.8.5 -> 12.8.6
d4148a7 
(cherry picked from commit 281bd03)
@flokli flokli force-pushed the 19.09-gitlab-12.8.6 branch from 4c6cc2c to d4148a7 Compare March 12, 2020 11:55
@flokli flokli merged commit 71b727e into NixOS:release-19.09 Mar 12, 2020
@flokli flokli deleted the 19.09-gitlab-12.8.6 branch March 12, 2020 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talyz talyz Awaiting requested review from talyz

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

@Ma27 Ma27 Awaiting requested review from Ma27

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@flokli