Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

denemo: add WrapGAppsHook #72903

Merged
merged 1 commit into from
Nov 15, 2019
Merged

denemo: add WrapGAppsHook #72903

merged 1 commit into from
Nov 15, 2019

Conversation

kylesferrazza
Copy link
Member

@kylesferrazza kylesferrazza commented Nov 6, 2019 •
edited
Loading

closes #52958

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Nov 6, 2019
@jtojnar
Copy link
Member

jtojnar commented Nov 15, 2019

Could you squash the commits? Otherwise LGTM.

@jtojnar
Copy link
Member

jtojnar commented Nov 15, 2019 •
edited
Loading

Though, while at it, could you also clean up the package a bit. gettext and pkgconfig should move to nativeBuildInputs as well.

@kylesferrazza
denemo: add WrapGAppsHook
5f37370 
closes NixOS#52958

remove wrapProgram in favor of gappsWrapperArgs
move gettext and pkgconfig to nativeBuildInputs
@jtojnar jtojnar merged commit 4a3a31b into NixOS:master Nov 15, 2019
@jtojnar
Copy link
Member

jtojnar commented Nov 15, 2019

Thanks.

@kylesferrazza kylesferrazza deleted the fix-52958 branch November 11, 2020 03:01
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

denemo "GLib-GIO - ERROR : No GSettings schemas are installed on the system"
3 participants
@kylesferrazza @jtojnar @Janik-Haag