Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspell: 0.60.6.1 -> 0.60.8 #71242

Merged
merged 1 commit into from
Nov 23, 2019
Merged

aspell: 0.60.6.1 -> 0.60.8 #71242

merged 1 commit into from
Nov 23, 2019

Conversation

lsix
Copy link
Member

@lsix lsix commented Oct 16, 2019

See http://aspell.net/aspell-0.60.8.txt for release information.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 25, 2019

@GrahamcOfBorg eval

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 25, 2019

We miss the darwin build
@GrahamcOfBorg build aspell

c0bw3b
c0bw3b approved these changes Oct 25, 2019
View reviewed changes
Copy link
Contributor

@c0bw3b c0bw3b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could build most direct reverse-deps

Result of nix-review pr 71242 1

1 package failed to build:
  • retext (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
18 package were build:
  • aspell (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • ding (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • eiskaltdcpp (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • enchant (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • enchant1 (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • gnustep.base (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • gtkspell2 (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • gtkspell3 (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • jucipp (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • onboard (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • paperwork (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • perl528Packages.TextAspell (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • perl530Packages.TextAspell (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • pidgin (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • scowl (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • texmacs (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • weechat-unwrapped (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)
  • xmlcopyeditor (enchant2 ,gnome3.empathy ,gnome3.epiphany ,gnome3.evince ,gnome3.evolution-data-server ,gnome3.evolution_data_server ,gnome3.folks ,gnome3.gfbgraph ,gnome3.gitg ,gnome3.gnome-notes ,gnome3.gnome-online-accounts ,gnome3.gnome-photos ,gnome3.gnome-tweak-tool ,gnome3.gnome_control_center ,gnome3.gnome_online_accounts ,gnome3.gnome_session ,gnome3.gnome_shell ,gnome3.gnome_terminal ,gnome3.grilo-plugins ,gnome3.gspell ,gnome3.libgdata ,gnome3.libgepub ,libsForQt512.fcitx-qt5 ,gnome3.libzapojit ,gnome3.shotwell ,gnome3.tracker-miners ,gnome3.yelp)

retext failure is only because chardet override fails during patching phase :

builder for '/nix/store/y3j9jfr8vcjzfyxi4x8yz12abdhqv5ws-python3.7-chardet-3.0.4.drv' failed with exit code 1; last 10 log lines:
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |--- a/test.py
  |+++ b/test.py
  --------------------------
  File to patch: 
  Skip this patch? [y] 
  Skipping patch.
  1 out of 1 hunk ignored
cannot build derivation '/nix/store/ziql73my8d0al1yijsqazfl3vpfchpr4-python3-3.7.5-env.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ij9y77a63259gd8y76g4lf8qgzw8m4i1-retext-7.0.4.drv': 1 dependencies couldn't be built

It's already failing on Hydra and is unrelated to this change

@c0bw3b
Copy link
Contributor

c0bw3b commented Oct 25, 2019

To go with #71557 in an upcoming staging batch

@risicle
Copy link
Contributor

risicle commented Nov 23, 2019

Could someone add the security label to this please? https://nvd.nist.gov/vuln/detail/CVE-2019-17544

@risicle risicle mentioned this pull request Nov 23, 2019
Merged
10 tasks
@c0bw3b c0bw3b added the 1.severity: security Issues which raise a security issue, or PRs that fix one label Nov 23, 2019
@c0bw3b c0bw3b merged commit 648678f into NixOS:staging Nov 23, 2019
@risicle
Copy link
Contributor

risicle commented Nov 24, 2019

Even better.

wamserma pushed a commit to wamserma/nixpkgs that referenced this pull request Feb 10, 2020
@lsix @wamserma
aspell: 0.60.6.1 -> 0.60.8
24ad802 
See http://aspell.net/aspell-0.60.8.txt for release information.
(NixOS#71242)

The fix for CVE-2019-20433 may break compatibility for some
applications, hence a version bump instead of adding a patch.

Also: backport of 648678f
@wamserma wamserma mentioned this pull request Feb 10, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c0bw3b c0bw3b c0bw3b approved these changes

@philandstuff philandstuff philandstuff approved these changes

Assignees
No one assigned
Labels
1.severity: security Issues which raise a security issue, or PRs that fix one 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lsix @c0bw3b @risicle @philandstuff