Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradio: clean-up #55452

Closed
wants to merge 1 commit into from
Closed

gradio: clean-up #55452

wants to merge 1 commit into from

Conversation

Anton-Latukha
Copy link
Contributor

@Anton-Latukha Anton-Latukha commented Feb 8, 2019 •
edited
Loading

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 8, 2019
@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Feb 8, 2019 •
edited
Loading

Side note for @samdroid-apps:

Gradio development was abandoned, and in the same Git repo the complete rewrite in Rust started - the ShortWave. Also main repo was moved to GNOME GitLab. Main dev said to me about the stable release that "Don't expect anything soon, but you will know when the first version is released :)".

So you probably want to support future stable releases of the ShortWave.

jtojnar
jtojnar approved these changes Feb 8, 2019
View reviewed changes
jtojnar
jtojnar requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bah, did not mean to approve yet

@Anton-Latukha Anton-Latukha force-pushed the gradio-upd branch 2 times, most recently from 3fbc821 to 582785f Compare February 8, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

Assignees
No one assigned
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Anton-Latukha @jtojnar @GrahamcOfBorg @markuskowa