Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: vim-go: make gocode, gocode-mod and keyify available to it #49815

Merged
merged 4 commits into from
Nov 6, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions pkgs/development/tools/gocode-gomod/default.nix
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
{ stdenv, buildGoPackage, fetchFromGitHub }:

buildGoPackage rec {
name = "gocode-gomod-unstable-${version}";
version = "2018-10-16";
rev = "12640289f65065d652cc942ffa01a52bece1dd53";

goPackagePath = "github.com/stamblerre/gocode";

# we must allow references to the original `go` package,
# because `gocode` needs to dig into $GOROOT to provide completions for the
# standard packages.
allowGoReference = true;

excludedPackages = ''internal/suggest/testdata'';

src = fetchFromGitHub {
inherit rev;

owner = "stamblerre";
repo = "gocode";
sha256 = "1avv0b5p2l8pv38m5gg97k57ndr5k9yy0rfkmmwjq96pa221hs1q";
};

goDeps = ./deps.nix;

postInstall = ''
mv $bin/bin/gocode $bin/bin/gocode-gomod
'';

meta = with stdenv.lib; {
description = "An autocompletion daemon for the Go programming language";
longDescription = ''
Gocode is a helper tool which is intended to be integrated with your
source code editor, like vim, neovim and emacs. It provides several
advanced capabilities, which currently includes:

- Context-sensitive autocompletion

It is called daemon, because it uses client/server architecture for
caching purposes. In particular, it makes autocompletions very fast.
Typical autocompletion time with warm cache is 30ms, which is barely
noticeable.
'';
homepage = https://github.com/stamblerre/gocode;
license = licenses.mit;
platforms = platforms.all;
maintainers = with maintainers; [ kalbasit ];
};
}
11 changes: 11 additions & 0 deletions pkgs/development/tools/gocode-gomod/deps.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 4 additions & 9 deletions pkgs/development/tools/gocode/default.nix
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

buildGoPackage rec {
name = "gocode-unstable-${version}";
version = "2018-10-22";
rev = "e893215113e5f7594faa3a8eb176c2700c921276";
version = "2018-11-05";
rev = "0af7a86943a6e0237c90f8aeb74a882e1862c898";

goPackagePath = "github.com/mdempsky/gocode";
excludedPackages = ''internal/suggest/testdata'';

# we must allow references to the original `go` package,
# because `gocode` needs to dig into $GOROOT to provide completions for the
Expand All @@ -17,17 +18,11 @@ buildGoPackage rec {

owner = "mdempsky";
repo = "gocode";
sha256 = "1zsll7yghv64890k7skl0g2lg9rsaiisgrfnb8kshsxrcxi1kc2l";
sha256 = "0fxqn0v6dbwarn444lc1xrx5vfkcidi73f4ba7l4clsb9qdqgyam";
};

goDeps = ./deps.nix;

preBuild = ''
# getting an error building the testdata because they contain invalid files
# on purpose as part of the testing.
rm -r go/src/$goPackagePath/internal/suggest/testdata
'';

meta = with stdenv.lib; {
description = "An autocompletion daemon for the Go programming language";
longDescription = ''
Expand Down
4 changes: 2 additions & 2 deletions pkgs/development/tools/gocode/deps.nix

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 6 additions & 3 deletions pkgs/misc/vim-plugins/overrides.nix
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
, asmfmt, delve, errcheck, godef, golint
, gomodifytags, gotags, gotools, motion
, gnused, reftools, gogetdoc, gometalinter
, impl, iferr
, impl, iferr, gocode, gocode-gomod, go-tools
}:

let
Expand Down Expand Up @@ -261,6 +261,9 @@ with generated;
asmfmt
delve
errcheck
go-tools
gocode
gocode-gomod
Copy link
Member

@Mic92 Mic92 Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does gocode-gomode? It looks a bit like gocode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was taken by this as well. gocode-gomod is a fork of gocode with support for Go modules. Unfortunately, neither project can replace the other!

See gocode README https://github.com/mdempsky/gocode#githubcommdempskygocode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is vim-go smart enough to switch between the too?

Copy link
Member Author

@kalbasit kalbasit Nov 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it is. it installs it here and uses it here.

godef
gogetdoc
golint
Expand All @@ -276,8 +279,8 @@ with generated;
in {
postPatch = ''
${gnused}/bin/sed \
-Ee 's@let go_bin_path = go#path#BinPath\(\)@let go_bin_path = "${binPath}"@g' \
-i autoload/go/path.vim
-Ee 's@"go_bin_path", ""@"go_bin_path", "${binPath}"@g' \
-i autoload/go/config.vim
'';
});

Expand Down
2 changes: 2 additions & 0 deletions pkgs/top-level/all-packages.nix
Original file line number Diff line number Diff line change
Expand Up @@ -14705,6 +14705,8 @@ with pkgs;

gocode = callPackage ../development/tools/gocode { };

gocode-gomod = callPackage ../development/tools/gocode-gomod { };

goconst = callPackage ../development/tools/goconst { };

goconvey = callPackage ../development/tools/goconvey { };
Expand Down