PythonFull improvements

[domenkozar]

No description provided.

[domenkozar]

Ready for review.

[peti]

Wow, there are a lot of changes ...

[aristidb]

I believe those parens are not required.

[domenkozar]

Fixed

[aristidb]

What exactly is pythonFullWithPkgs?

[domenkozar]

pythonFullWithPkgs could be called also something like pythonFullBundle, you can specify what packages environment would include and get a python interpreter with all those packages. It uses buildEnv internally. Previously it was called pythonFull, which got unfortunate results when used with nix-shell

[garbas]

i would rename pythonFullWithPkgs to createEnv and place it on python attr path itself eg. python27.createEnv, python26.createEnv. as you said it about creating python environments and lets call it then something similar.

those of you who work with python+nixpkgs you might notice that how we handle python is fairly broken, since what can happen is that in python environment we create multiple versions of the same package can be placed in PYTHONPATH. what is even more scary is that this many times happens silently and while you think your project is using version you specified you are actually using some other version which got pulled in as dependency of some other package.

anyway +1 for the change i'll test it this week on our code and report back if there are any errors, but please lets use some more saner naming.

[domenkozar]

I fully agree with python.createEnv, I'll rename it tomorrow.

For "fairly broken part", this is the issue: #2412

[domenkozar]

@garbas can't actually do that. pythonFullWithPkgs has a dependency on pythonPackages.recursivePthLoader and putting that inside python interpreter creates inf. recursion. We can name it pythonFullCreateEnv if you'd like.

[garbas]

+1